Skip to content

[ENHANCEMENT] Refactor assigning value ibpi_prev in _send_msg. #235

@bkucman

Description

@bkucman

Description

Currently, the send message function assigns the pattern determined by ledmon every time, regardless whether the controller returned a success or not. This mechanism should start recognizing whether the pattern was written successfully, and handle these states accordingly.

Reason

  • Failure of the controller to write supported pattern leads to the fact that there will be no attempt to enter it again, because the controller does not attempt to write it if actual ibpi is the same as prev.
  • incorrect patterns determined by ledmon are also entered into ibpi_prev, which seems logically incorrect, such a case should have its own error handling, it may hide an error in implementation or events.

Environment

N/A

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions