Conduct props audit

[abhishekashyap]

This discussion is to conduct a prop audit as and determine proper prop conventions or renames for the next major release.

Agenda/Open Questions

• Conventions for boolean (error vs isError vs hasError)

error // Short
isError // Signfies it is a boolean value
hasError // Unclear

• Should we be using HTML-based prop names or custom prop names for props that also exist as attributes? (disabled vs isDisabled for a button)

<Button isDisabled />
<Button disabled />

• Differentiating between nouns and adjectives named props

• For numeric values, if the values begin with 0, we should probably suffix prop with index

page // Doesn't signify if it is a numeric value or if it supports 0 as a value
pageIndex // Signifies it is a numeric value that starts with 0

• For event handlers (onClick, onChange, etc), we should probably get rid of reccuring component name in the prop. For e.g. we have onInputChange for the Input component, ideally it should have onChange function as the developer already knows it is an Input component

• For string-based props we can suffix the prop name with text

label // Since it is a noun, it signifies that it can accept any value - probably a React element or string
labelText // Signifies that it only accepts string values