MBS-14183: Generate placeholder email for editor sanitized dumps #3663
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlpharoah
force-pushed
the
mbs-14183
branch
2 times, most recently
from
0bf146e to
1efe1d3
Compare
Member
|
You can just drop the MBS-14137 commit and force-push rather than remove the code in the next commit :) |
mwiencek
requested changes
Nov 12, 2025
owlpharoah
force-pushed
the
mbs-14183
branch
4 times, most recently
from
32b9e8a to
5a4b49b
Compare
mwiencek
reviewed
Nov 13, 2025
owlpharoah
force-pushed
the
mbs-14183
branch
from
5a4b49b to
ca8e449
Compare
mwiencek
approved these changes
Nov 19, 2025
Member
mwiencek
left a comment
mwiencek
left a comment
There was a problem hiding this comment.
LGTM, thanks for quickly addressing the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While testing changes to the MusicBrainz server, contributors need to verify behavior involving email-confirmed users. However, the local development database lacks test users with emails when using sanitized dumps, making it hard to test features dependent on email confirmation.
Solution MBS-14183
Modified $EDITOR_SANITISED_COLUMNS in lib/MusicBrainz/Server/Constants.pm to automatically generate placeholder emails in the format
editor-{editor-id}@musicbrainz.invalidinstead of blank strings.