Fix expect_column_to_exist rendering Python booleans as SQL literals#45
Merged
GuruM merged 1 commit intoMay 17, 2026
Merged
Conversation
Use integer literals (1/0) instead of Python True/False, which are not valid SQL on T-SQL dialects (Microsoft Fabric, SQL Server, Azure SQL). Fixes metaplane#43
There was a problem hiding this comment.
Pull request overview
This PR fixes expect_column_to_exist SQL rendering for T-SQL-based adapters by avoiding Python boolean literals in generated SQL.
Changes:
- Replaces rendered
true/falsevalues with integer1/0. - Updates the final predicate to compare the integer flag explicitly with
= 1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuruM
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
True/Falsewith integer literals1/0in theexpect_column_to_existtest macro= 1comparison in theWHEREclause instead of relying on implicit boolean evaluationTrue/Falseare invalid SQL literals on those platformsFixes #43
Test plan
expect_column_to_existtest on a T-SQL adapter (dbt-fabric, dbt-sqlserver) — should no longer errorexpect_column_to_existtest on PostgreSQL/Snowflake/BigQuery — should still pass (integer1/0work as booleans on all platforms)column_indexparameter