Fix positional GROUP BY in expect_column_values_to_have_consistent_casing#46
Merged
GuruM merged 1 commit intoMay 17, 2026
Conversation
Replace `GROUP BY 1` with `GROUP BY lower(distinct_values)`. T-SQL dialects (Microsoft Fabric, SQL Server, Azure SQL) do not support positional GROUP BY references. Fixes metaplane#44
There was a problem hiding this comment.
Pull request overview
This PR fixes a cross-dialect compatibility issue in the expect_column_values_to_have_consistent_casing schema test by removing positional GROUP BY usage, which fails on T-SQL adapters (SQL Server / Azure SQL / Fabric).
Changes:
- Replaces
GROUP BY 1with an explicitGROUP BY lower(distinct_values)in thedisplay_inconsistent_columns=Truequery path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuruM
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GROUP BY 1withGROUP BY lower(distinct_values)in theexpect_column_values_to_have_consistent_casingtest macroGROUP BYreferencesFixes #44
Test plan
expect_column_values_to_have_consistent_casingwithdisplay_inconsistent_columns=Trueon a T-SQL adapter — should no longer errordisplay_inconsistent_columns=Trueanddisplay_inconsistent_columns=Falsepaths