From 29c25b4b4f102e977297d4a16f47f8fd46ac4597 Mon Sep 17 00:00:00 2001
From: Adam Heinz <adam.heinz@metricwise.com>
Date: Fri, 20 Mar 2026 11:19:36 -0400
Subject: [PATCH] [IMP] OO-1391 Don't enclose shared favorites in accordion.

---
 .../search_bar_menu/search_bar_menu.xml       |  9 -----
 .../search_bar_menu/favorite_menu.test.js     | 38 -------------------
 2 files changed, 47 deletions(-)

diff --git a/addons/web/static/src/search/search_bar_menu/search_bar_menu.xml b/addons/web/static/src/search/search_bar_menu/search_bar_menu.xml
index 531df779893ff4..b7a18fb5d63d6f 100644
--- a/addons/web/static/src/search/search_bar_menu/search_bar_menu.xml
+++ b/addons/web/static/src/search/search_bar_menu/search_bar_menu.xml
@@ -142,18 +142,9 @@
                         <t t-if="favoriteItems.length">
                             <div role="separator" class="dropdown-divider"/>
                         </t>
-                        <t t-if="sharedFavoritesItems.length > 10">
-                            <AccordionItem class="'o_shared_favorites text-truncate'" description.translate="Shared filters">
-                                <t t-foreach="sharedFavoritesItems" t-as="item" t-key="item.id">
-                                    <t t-call="web.SearchBarMenu.FavoriteItem" />
-                                </t>
-                            </AccordionItem>
-                        </t>
-                        <t t-else="">
                             <t t-foreach="sharedFavoritesItems" t-as="item" t-key="item.id">
                                 <t t-call="web.SearchBarMenu.FavoriteItem" />
                             </t>
-                        </t>
                         <div t-if="sharedFavoritesItems.length" role="separator" class="dropdown-divider"/>
                         <t t-set="currentGroup" t-value="null"/>
                         <t t-foreach="otherItems" t-as="item" t-key="item.key">
diff --git a/addons/web/static/tests/search/search_bar_menu/favorite_menu.test.js b/addons/web/static/tests/search/search_bar_menu/favorite_menu.test.js
index f8006f22132239..1e21619ac609c2 100644
--- a/addons/web/static/tests/search/search_bar_menu/favorite_menu.test.js
+++ b/addons/web/static/tests/search/search_bar_menu/favorite_menu.test.js
@@ -298,41 +298,3 @@ test("edit a favorite with a groupby", async () => {
     await toggleSearchBarMenu();
     expect(`.o_group_by_menu .o_menu_item:not(.o_add_custom_group_menu)`).toHaveCount(0);
 });
-
-test("shared favorites are grouped under a dropdown if there are more than 10", async () => {
-    onRpc("create_or_replace", ({ args, route }) => {
-        expect.step(route);
-        const irFilter = args[0];
-        expect(irFilter.domain).toBe(`[]`);
-        return 10; // fake serverSideId
-    });
-    const irFilters = [];
-    for (let i = 1; i < 11; i++) {
-        irFilters.push({
-            context: "{}",
-            domain: "[('foo', '=', 'a')]",
-            id: i,
-            is_default: false,
-            name: "My favorite" + i,
-            sort: "[]",
-        });
-    }
-    await mountWithSearch(SearchBarMenu, {
-        resModel: "foo",
-        searchMenuTypes: ["favorite"],
-        searchViewId: false,
-        irFilters,
-        activateFavorite: false,
-    });
-    await toggleSearchBarMenu();
-    expect(".o_favorite_menu .o-dropdown-item").toHaveCount(10);
-    await toggleSaveFavorite();
-    await editFavoriteName("My favorite11");
-    await contains(".o-checkbox:eq(1)").click();
-    await saveFavorite();
-    expect.verifySteps(["/web/dataset/call_kw/ir.filters/create_or_replace"]);
-    expect(".o_favorite_menu .o-dropdown-item").toHaveCount(0);
-    expect(".o_favorite_menu .o_menu_item:contains(Shared filters)").toHaveCount(1);
-    await contains(".o_favorite_menu .o_menu_item:contains(Shared filters)").click();
-    expect(".o_favorite_menu .o-dropdown-item").toHaveCount(11);
-});