From 60262827aabaa835a2f1ceb09b0740c009f8a048 Mon Sep 17 00:00:00 2001 From: Mac Mini Date: Tue, 16 Sep 2025 07:39:29 +0200 Subject: [PATCH] fix: remove incorrect and unused type guards - Remove isRxStatefulConfigOrObsGuard (unused and too generic) - Remove isRxStatefulConfigOrSourceTriggerConfigGuard (incorrect implementation) - Remove isObservableOrSubjectGuard (only used by removed guards) - Clean up unused imports from rxjs Closes #50 --- libs/rx-stateful/src/lib/types/guards.ts | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/libs/rx-stateful/src/lib/types/guards.ts b/libs/rx-stateful/src/lib/types/guards.ts index d262f4c..8525e20 100644 --- a/libs/rx-stateful/src/lib/types/guards.ts +++ b/libs/rx-stateful/src/lib/types/guards.ts @@ -1,24 +1,9 @@ -import {RxStatefulConfig, SourceTriggerConfig} from "./types"; -import {isObservable, Observable, Subject} from "rxjs"; +import { SourceTriggerConfig } from './types'; - -export function isObservableOrSubjectGuard(arg: any): arg is Observable | Subject{ - return isObservable(arg) || arg instanceof Subject; -} - -export function isRxStatefulConfigOrObsGuard(arg: any): arg is RxStatefulConfig{ - // write type guard for RxStatefulConfig - return !(isObservableOrSubjectGuard(arg)) -} - -export function isRxStatefulConfigOrSourceTriggerConfigGuard(arg: any): arg is RxStatefulConfig{ - // write type guard for RxStatefulConfig - return (arg as any)?.trigger !== undefined -} export function isFunctionGuard(value: any): value is (...args: any[]) => any { - return typeof value === 'function'; + return typeof value === 'function'; } -export function isSourceTriggerConfigGuard(arg: any): arg is SourceTriggerConfig{ - return arg?.sourceTriggerConfig !== undefined; +export function isSourceTriggerConfigGuard(arg: any): arg is SourceTriggerConfig { + return arg?.sourceTriggerConfig !== undefined; }