[Change Request] codeunit 22 "Item Jnl.-Post Line" procedure InsertValueEntry

[AurimasPileckis]

Why do you need this change?

We need the ShouldInsertValueEntry boolean in the InsertValueEntry procedure and OnBeforeInsertValueEntryProcedure event so extensions can prevent value entry creation in specific scenarios. This allows us to apply custom business logic and avoid unnecessary or incorrect value entries, improving flexibility and data integrity.

Describe the request

On behalf of 4PS I would like to request to implement ShouldInsertValueEntry boolean in InsertValueEntry procedure, codeunit 22 "Item Jnl.-Post Line".
Internal work item: AB#622669

[AleksandricMarko]

Hi @AurimasPileckis,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

Missing Information:

• Alternatives Evaluated: Please describe which existing events or patterns you tried and why they were insufficient for your needs.

• Justification for IsHandled: Please explain why a standard event, redesign, or contribution isn't feasible. Why is the IsHandled parameter specifically necessary? For example, explain the concrete business logic that must be skipped/replaced and why alternative approaches won't work.

• Performance Considerations: Please provide information about the expected execution frequency of this event and assess potential performance impact.

• Data Sensitivity Review: Please confirm there is no sensitive data exposure, or provide rationale if exposure is necessary.

• Multi-Extension Interaction: Please describe the risks if multiple extensions subscribe to this event and how conflicts would be mitigated.

Please update the issue with the missing details. We'll automatically re-analyze once updated.

[AurimasPileckis]

Alternatives Evaluated:
This procedure has references in 5 places, all of them in same codeunit. In 2 places there already are IsHandled defined, but in the remaining 3 there is no way to skip this procedure.

Justification for IsHandled:
A standard event or redesign is not feasible because our business logic sometimes requires that the value entry is not inserted at all (e.g., we have introduced a Consignment stock functionality in Stockkeeping Unit and if it's enabled we don't create value entries during Item Journal Line posting). The IsHandled parameter is necessary to allow extensions to fully override and bypass the Microsoft insertion logic, which cannot be achieved with standard event subscriptions. This ensures data integrity and supports complex requirements that cannot be addressed by existing patterns.

Performance Considerations:
The event is triggered only during item journal posting, which is transactional and not high-frequency. The performance impact is minimal and limited to this process.

Data Sensitivity Review:
No sensitive data is exposed by the event or parameter.

Multi-Extension Interaction:
Extensions that rely on this event must coordinate via dependency declarations. Partners can use EventSubscriberInstance = Manual to control execution order.

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add IsHandled events before InsertValueEntry calls in the 3 remaining procedures that don't yet have them (2 of 5 call sites already have IsHandled support).

---

Location 1: InsertVarValueEntry procedure (around line 3026)

// Add IsHandled check before InsertValueEntry call
IsHandled := false;
OnBeforeInsertValueEntryFromInsertVarValueEntry(ValueEntry, GlobalItemLedgEntry, IsHandled);
if IsHandled then
    exit;

InsertValueEntry(ValueEntry, GlobalItemLedgEntry, false);

Event Publisher:

[IntegrationEvent(false, false)]
local procedure OnBeforeInsertValueEntryFromInsertVarValueEntry(var ValueEntry: Record "Value Entry"; var GlobalItemLedgEntry: Record "Item Ledger Entry"; var IsHandled: Boolean)
begin
end;

---

Location 2: InsertTransferEntry procedure (around line 3100)

InsertItemLedgEntry(NewItemLedgEntry, true);

// Add IsHandled check before InsertValueEntry call
IsHandled := false;
OnBeforeInsertValueEntryFromInsertTransferEntry(NewValueEntry, NewItemLedgEntry, IsHandled);
if IsHandled then
    exit;

InsertValueEntry(NewValueEntry, NewItemLedgEntry, true);

Event Publisher:

[IntegrationEvent(false, false)]
local procedure OnBeforeInsertValueEntryFromInsertTransferEntry(var NewValueEntry: Record "Value Entry"; var NewItemLedgEntry: Record "Item Ledger Entry"; var IsHandled: Boolean)
begin
end;

---

Location 3: InsertCorrValueEntry procedure (around line 4700)

NewValueEntry."Item Register No." := ItemReg."No.";

// Add IsHandled check before NewValueEntry.Insert
ShouldInsertValueEntry := true;
OnBeforeInsertValueEntryFromInsertCorrValueEntry(NewValueEntry, ItemLedgEntry, ShouldInsertValueEntry);
if not ShouldInsertValueEntry then
    exit;

NewValueEntry.Insert(true);

Event Publisher:

[IntegrationEvent(false, false)]
local procedure OnBeforeInsertValueEntryFromInsertCorrValueEntry(var NewValueEntry: Record "Value Entry"; var ItemLedgEntry: Record "Item Ledger Entry"; var ShouldInsertValueEntry: Boolean)
begin
end;

---

File: ItemJnlPostLine.Codeunit.al