[Extensibility request] Table 11401 "CBG Statement Line" | Table 11400 "CBG Statement" | Table 11307 "G/L Entry Application Buffer" | Table 11000000 "Proposal Line" - procedure ShowDimensions

[UrbMigle]

Why do you need this change?

Hello,

On behalf of 4PS, I'd like to request a change in the ShowDimensions procedures in the:
Table 11401 "CBG Statement Line" procedure ShowDimensions
Table 11400 "CBG Statement" procedure ShowDimensions
Table 11307 "G/L Entry Application Buffer" procedure ShowDimensions
Table 11000000 "Proposal Line" procedure ShowDimensions
Table 11000000 "Proposal Line" procedure ShowHeaderDimensions

There EditDimensionSet procedure is called without a Rec usage. We would like to have it improved by adding the Rec inside of the procedure call to use

procedure EditDimensionSet(RecVariant: Variant; DimSetID: Integer; NewCaption: Text[250]; var GlobalDimVal1: Code[20]; var GlobalDimVal2: Code[20]): Integer

instead of

procedure EditDimensionSet(DimSetID: Integer; NewCaption: Text[250]; var GlobalDimVal1: Code[20]; var GlobalDimVal2: Code[20]): Integer

Of codeunit 408 DimensionManagement.

Example from one of the objects:
Previous procedure:

    procedure ShowDimensions()
    begin
        "Dimension Set ID" := DimManagement.EditDimensionSet(
            "Dimension Set ID", StrSubstNo('%1 %2', "Journal Template Name", "No."),
            "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
    end;

New procedure:

    procedure ShowDimensions()
    begin
        "Dimension Set ID" := DimManagement.EditDimensionSet(
            Rec, "Dimension Set ID", StrSubstNo('%1 %2', "Journal Template Name", "No."), <--- Rec added
            "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
    end;

Describe the request

When calling the EditDimensionSet, in 4PS solution we have additional code that needs to happen before the Page "Edit Dimension Set Entries" is opened. In order to add additional functionality, we need to know from which record the procedure was called. Adding Rec to the specified procedure calls would allow us to implement the needed changes without requesting any additional events.

Thank you!
Internal work item: AB#622691

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Pass Rec as the first parameter to DimManagement.EditDimensionSet in each ShowDimensions/ShowHeaderDimensions procedure, switching to the overload that accepts RecVariant.

1. Table 11401 "CBG Statement Line" - ShowDimensions

Current code:

procedure ShowDimensions()
begin
    "Dimension Set ID" := DimManagement.EditDimensionSet(
        "Dimension Set ID", StrSubstNo('%1 %2 %3', "Journal Template Name", "No.", "Line No."),
        "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
end;

Proposed change:

procedure ShowDimensions()
begin
    "Dimension Set ID" := DimManagement.EditDimensionSet(
        Rec, "Dimension Set ID", StrSubstNo('%1 %2 %3', "Journal Template Name", "No.", "Line No."),
        "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
end;

File: CBGStatementLine.Table.al

---

2. Table 11400 "CBG Statement" - ShowDimensions

Current code:

procedure ShowDimensions()
begin
    "Dimension Set ID" := DimManagement.EditDimensionSet(
        "Dimension Set ID", StrSubstNo('%1 %2', "Journal Template Name", "No."),
        "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
end;

Proposed change:

procedure ShowDimensions()
begin
    "Dimension Set ID" := DimManagement.EditDimensionSet(
        Rec, "Dimension Set ID", StrSubstNo('%1 %2', "Journal Template Name", "No."),
        "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
end;

File: CBGStatement.Table.al

---

3. Table 11307 "G/L Entry Application Buffer" - ShowDimensions

Current code:

procedure ShowDimensions()
var
    DimManagement: Codeunit DimensionManagement;
begin
    "Dimension Set ID" := DimManagement.EditDimensionSet(
        "Dimension Set ID", StrSubstNo('%1 %2', "Entry No.", "G/L Account No."),
        "Global Dimension 1 Code", "Global Dimension 2 Code");
end;

Proposed change:

procedure ShowDimensions()
var
    DimManagement: Codeunit DimensionManagement;
begin
    "Dimension Set ID" := DimManagement.EditDimensionSet(
        Rec, "Dimension Set ID", StrSubstNo('%1 %2', "Entry No.", "G/L Account No."),
        "Global Dimension 1 Code", "Global Dimension 2 Code");
end;

File: GLEntryApplicationBuffer.Table.al

---

4. Table 11000000 "Proposal Line" - ShowDimensions

Current code:

[Scope('OnPrem')]
procedure ShowDimensions()
begin
    "Dimension Set ID" :=
      DimManagement.EditDimensionSet(
        "Dimension Set ID", StrSubstNo('%1 %2', "Our Bank No.", "Line No."));
end;

Proposed change:

[Scope('OnPrem')]
procedure ShowDimensions()
begin
    "Dimension Set ID" :=
      DimManagement.EditDimensionSet(
        Rec, "Dimension Set ID", StrSubstNo('%1 %2', "Our Bank No.", "Line No."),
        "Shortcut Dimension 1 Code", "Shortcut Dimension 2 Code");
end;

File: ProposalLine.Table.al

---

5. Table 11000000 "Proposal Line" - ShowHeaderDimensions

Current code:

[Scope('OnPrem')]
procedure ShowHeaderDimensions()
var
    HeaderGlobalDim1: Code[20];
    HeaderGlobalDim2: Code[20];
begin
    "Header Dimension Set ID" :=
      DimManagement.EditDimensionSet(
        "Header Dimension Set ID", StrSubstNo('%1 %2', "Our Bank No.", "Line No."),
        HeaderGlobalDim1, HeaderGlobalDim2);
end;

Proposed change:

[Scope('OnPrem')]
procedure ShowHeaderDimensions()
var
    HeaderGlobalDim1: Code[20];
    HeaderGlobalDim2: Code[20];
begin
    "Header Dimension Set ID" :=
      DimManagement.EditDimensionSet(
        Rec, "Header Dimension Set ID", StrSubstNo('%1 %2', "Our Bank No.", "Line No."),
        HeaderGlobalDim1, HeaderGlobalDim2);
end;

File: ProposalLine.Table.al