comment

Author: jsl517

packages/agents-a365-observability/src/configuration/PerRequestSpanProcessorConfiguration.ts

@@ -12,7 +12,8 @@ const DEFAULT_MAX_CONCURRENT_EXPORTS = 20;
 
 /**
  * Configuration for PerRequestSpanProcessor.
- * Inherits all observability and runtime settings, and adds per-request processor guardrails.
+ * Inherits runtime settings (clusterCategory, isNodeEnvDevelopment) and adds
+ * per-request processor guardrails.
  *
  * This is separated from ObservabilityConfiguration because PerRequestSpanProcessor
  * is used only in specific scenarios and these settings should not be exposed
@@ -24,7 +25,14 @@ export class PerRequestSpanProcessorConfiguration extends RuntimeConfiguration {
     const instanceOverrides = this.overrides as PerRequestSpanProcessorConfigurationOptions | undefined;
     return {
       ...(instanceOverrides ?? {}),
-      ...(internal ?? {}),
+      // Only pick per-request fields from internal overrides; runtime fields
+      // (clusterCategory, isNodeEnvDevelopment, etc.) are left to RuntimeConfiguration.
+      ...(internal && {
+        isPerRequestExportEnabled: internal.isPerRequestExportEnabled,
+        perRequestMaxTraces: internal.perRequestMaxTraces,
+        perRequestMaxSpansPerTrace: internal.perRequestMaxSpansPerTrace,
+        perRequestMaxConcurrentExports: internal.perRequestMaxConcurrentExports,
+      }),
     };
   }
 

packages/agents-a365-observability/src/internal/PerRequestProcessorInternalOverrides.ts

@@ -1,12 +1,12 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-import type { PerRequestSpanProcessorConfigurationOptions } from "../configuration/PerRequestSpanProcessorConfigurationOptions";
+import type { PerRequestSpanProcessorConfigurationOptions } from '../configuration/PerRequestSpanProcessorConfigurationOptions';
 
 let overrides: PerRequestSpanProcessorConfigurationOptions | undefined;
 
 // Only for tests / internal usage
-export function setPerRequestProcessorInternalOverrides(value?: PerRequestSpanProcessorConfigurationOptions) { 
+export function setPerRequestProcessorInternalOverrides(value?: PerRequestSpanProcessorConfigurationOptions) {
   overrides = value;
 }
 

tests/observability/internal/PerRequestProcessorOverrides.test.ts

@@ -14,7 +14,9 @@ import { ExportResultCode } from '@opentelemetry/core';
 // Mock Agent365Exporter to avoid network calls
 jest.mock('@microsoft/agents-a365-observability/src/tracing/exporter/Agent365Exporter', () => ({
   Agent365Exporter: class {
-    export() {/* no-op */}
+    export(_spans: unknown[], cb: (result: { code: number }) => void) {
+      cb({ code: 0 });
+    }
     shutdown() {/* no-op */}
     forceFlush() {/* no-op */}
   },
@@ -116,6 +118,6 @@ describe('PerRequestProcessorOverrides', () => {
     const builder = new ObservabilityBuilder().withService('test-agent');
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const processor = (builder as any).createExportProcessor();
-    expect(processor.constructor.name).toBe('PerRequestSpanProcessor');
+    expect(processor).toBeInstanceOf(PerRequestSpanProcessor);
   });
 });