From acb2672b9e74e0376cbb980f7592cc5587a22bde Mon Sep 17 00:00:00 2001 From: Josh Oratz Date: Thu, 13 Nov 2025 15:11:12 -0800 Subject: [PATCH 1/6] Add helper function to create activity with email response --- .../src/models/email-response.ts | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/agents-a365-notifications/src/models/email-response.ts b/packages/agents-a365-notifications/src/models/email-response.ts index fa0ad203..c07ba7b6 100644 --- a/packages/agents-a365-notifications/src/models/email-response.ts +++ b/packages/agents-a365-notifications/src/models/email-response.ts @@ -1,4 +1,4 @@ -import { Entity } from '@microsoft/agents-activity'; +import { Activity, Entity } from '@microsoft/agents-activity'; /** * Represents an email response entity to be sent back. @@ -29,3 +29,15 @@ export function createEmailResponse(htmlBody?: string): EmailResponse { htmlBody: htmlBody ?? '', }; } + +export function createEmailResponseActivity(emailResponseHtmlBody: string): Activity { + const workingActivity = Activity.fromObject({ + type: 'message', + entities: [] + }); + + workingActivity.entities = workingActivity.entities || []; + workingActivity.entities.push(createEmailResponse(emailResponseHtmlBody)); + + return workingActivity; +} From 9ae5c1266c9d9ac39af04c1512077ea7e7911b89 Mon Sep 17 00:00:00 2001 From: Josh Oratz Date: Thu, 13 Nov 2025 15:19:22 -0800 Subject: [PATCH 2/6] Fix lint issues --- .../src/models/email-response.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/agents-a365-notifications/src/models/email-response.ts b/packages/agents-a365-notifications/src/models/email-response.ts index c07ba7b6..71655331 100644 --- a/packages/agents-a365-notifications/src/models/email-response.ts +++ b/packages/agents-a365-notifications/src/models/email-response.ts @@ -30,14 +30,19 @@ export function createEmailResponse(htmlBody?: string): EmailResponse { }; } +/** + * Creates an activity with an EmailResponse entity + * @param emailResponseHtmlBody - The HTML body content for the email response + * @returns A message activity containing the EmailResponse entity + */ export function createEmailResponseActivity(emailResponseHtmlBody: string): Activity { const workingActivity = Activity.fromObject({ - type: 'message', - entities: [] - }); - + type: 'message', + entities: [] + }); + workingActivity.entities = workingActivity.entities || []; workingActivity.entities.push(createEmailResponse(emailResponseHtmlBody)); - + return workingActivity; } From 74e7b9379160beede5afec2b78f9e66d40e7411f Mon Sep 17 00:00:00 2001 From: Josh Oratz <43622754+joratz@users.noreply.github.com> Date: Thu, 13 Nov 2025 15:22:53 -0800 Subject: [PATCH 3/6] Update packages/agents-a365-notifications/src/models/email-response.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- packages/agents-a365-notifications/src/models/email-response.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/agents-a365-notifications/src/models/email-response.ts b/packages/agents-a365-notifications/src/models/email-response.ts index 71655331..6a364fce 100644 --- a/packages/agents-a365-notifications/src/models/email-response.ts +++ b/packages/agents-a365-notifications/src/models/email-response.ts @@ -41,7 +41,6 @@ export function createEmailResponseActivity(emailResponseHtmlBody: string): Acti entities: [] }); - workingActivity.entities = workingActivity.entities || []; workingActivity.entities.push(createEmailResponse(emailResponseHtmlBody)); return workingActivity; From c11b57040949c4b7461f654117f48adb89e20a39 Mon Sep 17 00:00:00 2001 From: Josh Oratz Date: Thu, 13 Nov 2025 15:26:53 -0800 Subject: [PATCH 4/6] Add definition back to avoid build issues This reverts commit 74e7b9379160beede5afec2b78f9e66d40e7411f. --- packages/agents-a365-notifications/src/models/email-response.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/agents-a365-notifications/src/models/email-response.ts b/packages/agents-a365-notifications/src/models/email-response.ts index 6a364fce..71655331 100644 --- a/packages/agents-a365-notifications/src/models/email-response.ts +++ b/packages/agents-a365-notifications/src/models/email-response.ts @@ -41,6 +41,7 @@ export function createEmailResponseActivity(emailResponseHtmlBody: string): Acti entities: [] }); + workingActivity.entities = workingActivity.entities || []; workingActivity.entities.push(createEmailResponse(emailResponseHtmlBody)); return workingActivity; From 4a625737996e245c118ed22eb872b28f74debcda Mon Sep 17 00:00:00 2001 From: Josh Oratz Date: Thu, 13 Nov 2025 15:30:18 -0800 Subject: [PATCH 5/6] apply copilot suggestions --- .../src/models/email-response.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/agents-a365-notifications/src/models/email-response.ts b/packages/agents-a365-notifications/src/models/email-response.ts index 71655331..ee44b944 100644 --- a/packages/agents-a365-notifications/src/models/email-response.ts +++ b/packages/agents-a365-notifications/src/models/email-response.ts @@ -32,17 +32,14 @@ export function createEmailResponse(htmlBody?: string): EmailResponse { /** * Creates an activity with an EmailResponse entity - * @param emailResponseHtmlBody - The HTML body content for the email response + * @param emailResponseHtmlBody - (Optional) The HTML body content for the email response * @returns A message activity containing the EmailResponse entity */ -export function createEmailResponseActivity(emailResponseHtmlBody: string): Activity { +export function createEmailResponseActivity(emailResponseHtmlBody?: string): Activity { const workingActivity = Activity.fromObject({ type: 'message', - entities: [] + entities: [createEmailResponse(emailResponseHtmlBody)] }); - workingActivity.entities = workingActivity.entities || []; - workingActivity.entities.push(createEmailResponse(emailResponseHtmlBody)); - return workingActivity; } From a97621e30377f57cc9d193ec5e26268075a9cf0c Mon Sep 17 00:00:00 2001 From: Josh Oratz Date: Thu, 13 Nov 2025 15:31:19 -0800 Subject: [PATCH 6/6] Remove const --- .../agents-a365-notifications/src/models/email-response.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/agents-a365-notifications/src/models/email-response.ts b/packages/agents-a365-notifications/src/models/email-response.ts index ee44b944..ced1b7d8 100644 --- a/packages/agents-a365-notifications/src/models/email-response.ts +++ b/packages/agents-a365-notifications/src/models/email-response.ts @@ -36,10 +36,8 @@ export function createEmailResponse(htmlBody?: string): EmailResponse { * @returns A message activity containing the EmailResponse entity */ export function createEmailResponseActivity(emailResponseHtmlBody?: string): Activity { - const workingActivity = Activity.fromObject({ + return Activity.fromObject({ type: 'message', entities: [createEmailResponse(emailResponseHtmlBody)] }); - - return workingActivity; }