diff --git a/evaluation/review-fixtures.json b/evaluation/review-fixtures.json index 7732e7e5..a43ec1f2 100644 --- a/evaluation/review-fixtures.json +++ b/evaluation/review-fixtures.json @@ -11,6 +11,21 @@ "breaking-changes": { "article": "do-not-expose-sensitive-data-through-public-api" }, + "data-modeling": { + "articles": [ + "check-blocked-in-referencing-code-not-in-master", + "code-must-not-change-workdate", + "pictures-must-use-media-not-blob", + "table-design-must-match-bc-table-type-conventions" + ] + }, + "error-handling": { + "articles": [ + "collect-validation-errors-with-errorbehavior", + "defensive-vs-offensive-code-must-match-blast-radius", + "log-writes-must-survive-rollback" + ] + }, "events": { "article": "reset-ishandled-only-when-the-value-can-carry-over" }, @@ -54,7 +69,9 @@ "use-setautocalcfields-for-per-row-flowfields", "temporary-tables-have-no-database-cost", "use-setloadfields-for-partial-records", - "prefer-modifyall-over-per-row-modify" + "prefer-modifyall-over-per-row-modify", + "al-methods-limited-during-write-transactions", + "avoid-user-prompts-inside-transactions" ] }, "privacy": { @@ -98,13 +115,16 @@ "security": { "articles": [ "al-has-no-built-in-htmlencode", - "do-not-concatenate-external-text-into-setfilter" + "do-not-concatenate-external-text-into-setfilter", + "exposed-objects-must-be-in-a-permission-set" ] }, "style": { "articles": [ "label-comment-explains-placeholders", - "dateformula-evaluate-needs-language-independent-literals" + "dateformula-evaluate-needs-language-independent-literals", + "al-comments-must-not-restate-what-code-already-shows", + "pages-must-not-contain-business-logic" ] }, "telemetry": { @@ -113,11 +133,30 @@ "testing": { "articles": [ "ui-handlers-in-tests", - "reset-per-test-state-before-the-isinitialized-guard" + "reset-per-test-state-before-the-isinitialized-guard", + "asserterror-needs-expectederror-and-code", + "bcpt-scenarios-must-be-app-specific", + "commit-shared-test-fixture-inside-lazy-initialize", + "given-blocks-must-cover-full-precondition-chain", + "table-relation-test-exclude-known-invalid-relations-via-event", + "test-feature-scenario-tags", + "test-one-when-per-test", + "transactionmodel-attribute-governs-test-transactions", + "ui-test-codeunit-naming", + "use-assert-isfalse-not-asserterror-for-boolean-checks" + ] + }, + "ui": { + "articles": [ + "default-descending-sort-on-historical-pages", + "page-design-must-match-bc-page-type-conventions" ] }, "upgrade": { - "article": "initvalue-does-not-update-existing-rows", + "articles": [ + "initvalue-does-not-update-existing-rows", + "upgrade-tag-logic-must-not-nest-deeply" + ], "context": "The extended table existed in the previous app version and already contains rows." }, "web-services": { @@ -126,7 +165,8 @@ "handle-httpclient-platform-failure-before-response-access", "check-http-status-before-consuming-response-body", "check-json-null-before-converting-values", - "format-exchanged-values-with-standard-format-9" + "format-exchanged-values-with-standard-format-9", + "api-page-least-privilege-write-access" ] } } diff --git a/microsoft/knowledge/style/al-comments-must-not-restate-what-code-already-shows.md b/microsoft/knowledge/style/al-comments-must-not-restate-what-code-already-shows.md index 09a2ea45..52c3c0a6 100644 --- a/microsoft/knowledge/style/al-comments-must-not-restate-what-code-already-shows.md +++ b/microsoft/knowledge/style/al-comments-must-not-restate-what-code-already-shows.md @@ -1,7 +1,7 @@ --- bc-version: [all] domain: style -keywords: [comments, verbosity, self-documenting, restate, tutorial-style] +keywords: [comments, verbosity, self-documenting, restate, tutorial-style, credit-memo-routing] technologies: [al] countries: [w1] application-area: [all] diff --git a/microsoft/knowledge/style/pages-must-not-contain-business-logic.md b/microsoft/knowledge/style/pages-must-not-contain-business-logic.md index 3326a258..ed5a4cb1 100644 --- a/microsoft/knowledge/style/pages-must-not-contain-business-logic.md +++ b/microsoft/knowledge/style/pages-must-not-contain-business-logic.md @@ -1,7 +1,7 @@ --- bc-version: [all] domain: style -keywords: [pages, business-logic, codeunit, separation-of-concerns, presentation-layer] +keywords: [pages, business-logic, codeunit, separation-of-concerns, presentation-layer, rec-modify] technologies: [al] countries: [w1] application-area: [all] diff --git a/microsoft/knowledge/testing/test-feature-scenario-tags.md b/microsoft/knowledge/testing/test-feature-scenario-tags.md index 2247c7ea..89198fb4 100644 --- a/microsoft/knowledge/testing/test-feature-scenario-tags.md +++ b/microsoft/knowledge/testing/test-feature-scenario-tags.md @@ -1,7 +1,7 @@ --- bc-version: [all] domain: testing -keywords: [feature, scenario, given, when, then, tags, bdd, atdd, comments] +keywords: [feature, scenario, given, when, then, tags, bdd, atdd, comments, subtype-test] technologies: [al] countries: [w1] application-area: [all]