From 357d41480148131dac85214136edc2e5138ae328 Mon Sep 17 00:00:00 2001
From: DavidKoleczek <45405824+DavidKoleczek@users.noreply.github.com>
Date: Tue, 25 Aug 2026 11:33:54 -0400
Subject: [PATCH] docs(skill): point the finish-release opencode gate at a
 check that exists
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Phase 4 told the runner to execute tests/test_version.py and
tests/test_prereqs.py in amplifier-app-opencode. Those files were removed in
that repo's PR #21, which retired its whole unit-test layer in favour of
spec-as-contract e2e coverage, so the command errors with "file or directory
not found" and no verification happens.

Point it at `make check` instead, and add a read-back of the three constants.
Lint accepts any string, so the read-back is what actually catches a wrong or
typo'd floor before it reaches a user's install. The e2e suites are not invoked
here: they need a DTU, they cost minutes, and the onboarding suite pins its fake
agent to 99.0.0 specifically so it does not track the floor.

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
---
 .../SKILL.md                                    | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/.amplifier/skills/amplifier-agent-finish-release-process/SKILL.md b/.amplifier/skills/amplifier-agent-finish-release-process/SKILL.md
index 4c54ef78..9b5a1611 100644
--- a/.amplifier/skills/amplifier-agent-finish-release-process/SKILL.md
+++ b/.amplifier/skills/amplifier-agent-finish-release-process/SKILL.md
@@ -222,12 +222,25 @@ existing entries: name the specific capability that forces this floor, and keep
 the historical notes about earlier floors. That comment is the record of why
 each bump happened, and dropping it loses real information.
 
-Then run its tests, which assert on these constants:
+Then run its fast gate, which is lint and format only:
 
 ```bash
-uv run pytest tests/test_version.py tests/test_prereqs.py -q
+make check
 ```
 
+Nothing in that repo asserts these constants. Its `tests/` tree is e2e-only and
+needs a DTU, so it does not run at this stage, and the onboarding suite
+deliberately does not track the floor anyway: the fake agent it installs reports
+`99.0.0`, comfortably above any real value. Read the constants back instead, and
+confirm they are the tag you actually pushed:
+
+```bash
+uv run python -c "from amplifier_app_opencode import prereqs as p; print(p.MIN_AGENT_VERSION, p.AGENT_PINNED_REF, p.AGENT_HARD_FLOOR)"
+```
+
+Lint accepts any string, so a typo here surfaces on a user's machine at install
+time rather than in this gate. That read-back is the check.
+
 Open a PR in `amplifier-app-opencode` with scope `chore(deps)` or `fix`,
 explaining which engine capability forces the floor. Do not merge it.