refactor: deprecate Text.replaceAll

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

Author: bmiddha

apps/api-extractor/src/analyzer/SourceFileLocationFormatter.ts

@@ -5,7 +5,7 @@ import * as path from 'node:path';
 
 import type * as ts from 'typescript';
 
-import { Path, Text } from '@rushstack/node-core-library';
+import { Path } from '@rushstack/node-core-library';
 
 export interface ISourceFileLocationFormatOptions {
   sourceFileLine?: number;
@@ -47,7 +47,7 @@ export class SourceFileLocationFormatter {
     }
 
     // Convert it to a Unix-style path
-    scrubbedPath = Text.replaceAll(scrubbedPath, '\\', '/');
+    scrubbedPath = scrubbedPath.replaceAll('\\', '/');
     result += scrubbedPath;
 
     if (options.sourceFileLine) {

apps/api-extractor/src/api/ExtractorConfig.ts

@@ -17,7 +17,6 @@ import {
   PackageJsonLookup,
   type INodePackageJson,
   PackageName,
-  Text,
   InternalError,
   Path,
   NewlineKind
@@ -1310,8 +1309,8 @@ function _expandStringWithTokens(
 ): string {
   value = value ? value.trim() : '';
   if (value !== '') {
-    value = Text.replaceAll(value, '<unscopedPackageName>', tokenContext.unscopedPackageName);
-    value = Text.replaceAll(value, '<packageName>', tokenContext.packageName);
+    value = value.replaceAll('<unscopedPackageName>', tokenContext.unscopedPackageName);
+    value = value.replaceAll('<packageName>', tokenContext.packageName);
 
     const projectFolderToken: string = '<projectFolder>';
     if (value.indexOf(projectFolderToken) === 0) {

apps/lockfile-explorer/src/graph/lfxGraphLoader.ts

@@ -4,8 +4,6 @@
 import type * as lockfileTypes from '@pnpm/lockfile.types';
 import type * as pnpmTypes from '@pnpm/types';
 
-import { Text } from '@rushstack/node-core-library';
-
 import {
   type ILfxGraphDependencyOptions,
   type ILfxGraphEntryOptions,
@@ -398,9 +396,9 @@ function createPackageLockfileEntry(options: {
 
       // Rewrite to:
       // "@rushstack/m@1.0.0; @rushstack/n@2.0.0"
-      suffix = Text.replaceAll(suffix, ')(', '; ');
-      suffix = Text.replaceAll(suffix, '(', '');
-      suffix = Text.replaceAll(suffix, ')', '');
+      suffix = suffix.replaceAll(')(', '; ');
+      suffix = suffix.replaceAll('(', '');
+      suffix = suffix.replaceAll(')', '');
       result.entrySuffix = suffix;
 
       //       @rushstack/l@1.0.0(@rushstack/m@1.0.0)(@rushstack/n@2.0.0)
@@ -412,10 +410,10 @@ function createPackageLockfileEntry(options: {
     // -->       @rushstack+l@1.0.0_@rushstack+m@1.0.0_@rushstack+n@2.0.0
 
     // @rushstack/l 1.0.0 (@rushstack/m@1.0.0)(@rushstack/n@2.0.0)
-    dotPnpmSubfolder = Text.replaceAll(slashlessRawEntryId, '/', '+');
-    dotPnpmSubfolder = Text.replaceAll(dotPnpmSubfolder, ')(', '_');
-    dotPnpmSubfolder = Text.replaceAll(dotPnpmSubfolder, '(', '_');
-    dotPnpmSubfolder = Text.replaceAll(dotPnpmSubfolder, ')', '');
+    dotPnpmSubfolder = slashlessRawEntryId.replaceAll('/', '+');
+    dotPnpmSubfolder = dotPnpmSubfolder.replaceAll(')(', '_');
+    dotPnpmSubfolder = dotPnpmSubfolder.replaceAll('(', '_');
+    dotPnpmSubfolder = dotPnpmSubfolder.replaceAll(')', '');
   }
 
   // Example:

apps/rundown/src/Rundown.ts

@@ -6,7 +6,7 @@ import * as path from 'node:path';
 
 import stringArgv from 'string-argv';
 
-import { FileSystem, PackageJsonLookup, Sort, Text } from '@rushstack/node-core-library';
+import { FileSystem, PackageJsonLookup, Sort } from '@rushstack/node-core-library';
 
 import type { IpcMessage } from './LauncherTypes';
 
@@ -57,7 +57,7 @@ export class Rundown {
           importedPackageFolders.add(path.basename(importedPackageFolder));
         } else {
           const relativePath: string = path.relative(process.cwd(), importedPackageFolder);
-          importedPackageFolders.add(Text.replaceAll(relativePath, '\\', '/'));
+          importedPackageFolders.add(relativePath.replaceAll('\\', '/'));
         }
       } else {
         // If the importedPath does not belong to an NPM package, then rundown-snapshot.log can ignore it.

common/changes/@rushstack/node-core-library/native-standard-apis_2026-08-18-03-14-05.json

@@ -2,7 +2,7 @@
   "changes": [
     {
       "packageName": "@rushstack/node-core-library",
-      "comment": "Delegate Text.replaceAll() to the native implementation, including native empty search string behavior.",
+      "comment": "Deprecate Text.replaceAll() in favor of the native String.prototype.replaceAll() method.",
       "type": "patch"
     }
   ],

common/reviews/api/node-core-library.api.md

@@ -968,6 +968,7 @@ export class Text {
     static padStart(s: string, minimumLength: number, paddingCharacter?: string): string;
     static readLinesFromIterable(iterable: Iterable<string | Buffer | null>, options?: IReadLinesFromIterableOptions): Generator<string>;
     static readLinesFromIterableAsync(iterable: AsyncIterable<string | Buffer>, options?: IReadLinesFromIterableOptions): AsyncGenerator<string>;
+    // @deprecated
     static replaceAll(input: string, searchValue: string, replaceValue: string): string;
     static reverse(s: string): string;
     static splitByNewLines(s: undefined): undefined;

libraries/node-core-library/src/JsonFile.ts

@@ -580,7 +580,7 @@ function _formatJsonHeaderComment(headerComment: string): string {
           JSON.stringify(line)
       );
     }
-    result.push(Text.replaceAll(line, '\r', ''));
+    result.push(line.replaceAll('\r', ''));
   }
   return lines.join('\n') + '\n';
 }

libraries/node-core-library/src/Text.ts

@@ -107,10 +107,12 @@ export class Text {
    * @param input         - The string to be modified
    * @param searchValue   - The value to search for
    * @param replaceValue  - The replacement text
+   *
+   * @deprecated Use `String.prototype.replaceAll()` instead.
    */
-   public static replaceAll(input: string, searchValue: string, replaceValue: string): string {
-     return input.replaceAll(searchValue, replaceValue);
-   }
+  public static replaceAll(input: string, searchValue: string, replaceValue: string): string {
+    return input.replaceAll(searchValue, replaceValue);
+  }
 
   /**
    * Converts all newlines in the provided string to use Windows-style CRLF end of line characters.

libraries/node-core-library/src/test/Executable.test.ts

@@ -17,7 +17,6 @@ import {
 } from '../Executable';
 import { FileSystem } from '../FileSystem';
 import { PosixModeBits } from '../PosixModeBits';
-import { Text } from '../Text';
 import { Readable } from 'node:stream';
 
 describe('Executable process tests', () => {
@@ -101,7 +100,7 @@ describe('Executable process tests', () => {
   test('Executable.tryResolve() pathless', () => {
     const resolved: string | undefined = Executable.tryResolve('npm-binary-wrapper', options);
     expect(resolved).toBeDefined();
-    const resolvedRelative: string = Text.replaceAll(path.relative(executableFolder, resolved!), '\\', '/');
+    const resolvedRelative: string = path.relative(executableFolder, resolved!).replaceAll('\\', '/');
 
     if (os.platform() === 'win32') {
       // On Windows, we should find npm-binary-wrapper.cmd instead of npm-binary-wrapper

libraries/node-core-library/src/test/Text.test.ts

@@ -4,17 +4,6 @@
 import { Text } from '../Text';
 
 describe(Text.name, () => {
-  describe(Text.replaceAll.name, () => {
-    it('replaces every occurrence', () => {
-      expect(Text.replaceAll('one two one', 'one', 'three')).toEqual('three two three');
-    });
-
-    it('uses native empty search string semantics', () => {
-      expect(Text.replaceAll('abc', '', '-')).toEqual('-a-b-c-');
-      expect(Text.replaceAll('', '', '-')).toEqual('-');
-    });
-  });
-
   describe(Text.padEnd.name, () => {
     it("Throws an exception if the padding character isn't a single character", () => {
       expect(() => Text.padEnd('123', 1, '')).toThrow();