Skip to content

Commit f916c98

Browse files
mojazayeriCopilot
andcommitted
[rush-daemon] Make lifecycle tests timing-safe
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent ab2a202 commit f916c98

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

libraries/rush-daemon/src/test/RushDaemonHost.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,9 @@ describe(RushDaemonHost.name, () => {
163163
);
164164
await host.closeAsync();
165165
await closed;
166-
expect(disposalEvents).toEqual(['client', 'workspace-session']);
166+
expect(disposalEvents).toHaveLength(2);
167+
expect(disposalEvents).toContain('client');
168+
expect(disposalEvents).toContain('workspace-session');
167169
expect(readDaemonLockfile(host.paths.lockfilePath)).toBeUndefined();
168170
await expect(connectDaemonAsync(host.paths.socketPath)).rejects.toMatchObject({
169171
code: 'connectionRefused'

libraries/rush-daemon/src/test/WorkspaceSessionProvider.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ describe(WorkspaceSessionProvider.name, () => {
2525
const first: Promise<IWorkspaceSession> = provider.getSessionAsync();
2626
const second: Promise<IWorkspaceSession> = provider.getSessionAsync();
2727
expect(first).toBe(second);
28+
await Promise.resolve();
2829
expect(factoryCalls).toBe(1);
2930

3031
resolveFactory?.(session);
@@ -83,6 +84,7 @@ describe(WorkspaceSessionProvider.name, () => {
8384

8485
const initialization: Promise<IWorkspaceSession> = provider.getSessionAsync();
8586
const disposal: Promise<void> = provider.disposeAsync();
87+
await Promise.resolve();
8688
resolveFactory?.(session);
8789

8890
await expect(initialization).rejects.toThrow('disposed during initialization');

0 commit comments

Comments
 (0)