Drop Node.js 18 support (#5926)

* build!: require Node.js 20 for development

BREAKING CHANGE: Rush Stack development and CI now require Node.js 20.9 or newer.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

* refactor!: remove Node.js 18 workarounds

BREAKING CHANGE: Node.js 18 is no longer supported by these runtime paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

* build(heft-node-rig): expose ES2022 libs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

* fix: align pnpm lockfile settings

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

---------

Copilot-Session: 8ebd5bf2-c44b-42d5-be25-e7936d4b0a14

Author: bmiddha

.github/workflows/ci.yml

@@ -12,14 +12,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          # When Node 18 is removed, remove the special cases in
-          # - build-tests-samples/heft-storybook-v9-react-tutorial/build.js
-          # - build-tests-samples/heft-storybook-v9-react-tutorial-app/build.js
-          # - The "globalOverrides" entry for "@vscode/vsce>cheerio" in common/config/rush/pnpm-config.json
-          # - libraries/module-minifier/src/cryptoPolyfill.ts
-          - NodeVersion: 18.20.x
-            NodeVersionDisplayName: 18
-            OS: ubuntu-latest
           - NodeVersion: 20.18.x
             NodeVersionDisplayName: 20
             OS: ubuntu-latest

.github/workflows/file-doc-tickets.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Use nodejs
         uses: actions/setup-node@v6
         with:
-          node-version: 16
+          node-version: 20
       - name: Parse PR body
         run: |
           cat <<-"EOF" > event.json

build-tests-samples/heft-storybook-v9-react-tutorial-app/build.js

@@ -5,9 +5,7 @@
   "operationSettings": [
     {
       "operationName": "_phase:lite-build",
-      "outputFolderNames": ["dist"],
-      // This project builds differently between Node 18 and other versions of Node
-      "dependsOnNodeVersion": "major"
+      "outputFolderNames": ["dist"]
     }
   ]
 }

build-tests-samples/heft-storybook-v9-react-tutorial-app/config/rush-project.json

@@ -5,7 +5,7 @@
   "private": true,
   "scripts": {
     "build": "heft build --clean --storybook",
-    "_phase:lite-build": "node ./build"
+    "_phase:lite-build": "heft run --only build -- --clean --storybook"
   },
   "dependencies": {
     "heft-storybook-v9-react-tutorial": "workspace: *"

build-tests-samples/heft-storybook-v9-react-tutorial-app/package.json

@@ -5,9 +5,7 @@
   "operationSettings": [
     {
       "operationName": "_phase:build",
-      "outputFolderNames": [".heft", "lib-esm", "lib-commonjs", "dist"],
-      // This project builds differently between Node 18 and other versions of Node
-      "dependsOnNodeVersion": "major"
+      "outputFolderNames": [".heft", "lib-esm", "lib-commonjs", "dist"]
     },
     {
       "operationName": "_phase:test",

build-tests-samples/heft-storybook-v9-react-tutorial/build.js

@@ -8,7 +8,7 @@
     "start": "heft build-watch",
     "storybook": "heft build-watch --serve --storybook",
     "build-storybook": "heft build --storybook",
-    "_phase:build": "node ./build",
+    "_phase:build": "heft run --only build -- --clean --storybook",
     "_phase:test": "heft run --only test -- --clean"
   },
   "dependencies": {

build-tests-samples/heft-storybook-v9-react-tutorial/config/rush-project.json

@@ -35,7 +35,7 @@ Tests Rush yarn mode by:
 Before running these tests:
 1. Build Rush locally: `rush build --to rush`
 2. Build this test project: `rush build --to rush-package-manager-integration-test`
-3. Ensure you have Node.js 18+ installed
+3. Ensure you have Node.js 20+ installed
 
 ## Running the Tests
 

build-tests-samples/heft-storybook-v9-react-tutorial/package.json

@@ -85,7 +85,7 @@ export class TestHelper {
     ];
 
     // Update nodeSupportedVersionRange to match current environment
-    rushJson.nodeSupportedVersionRange = '>=18.0.0';
+    rushJson.nodeSupportedVersionRange = '>=20.0.0';
 
     await JsonFile.saveAsync(rushJson, rushJsonPath, { updateExistingFile: true });
   }