Once upon a time, I made a typo in a filter rule (localtion instead of location) :
exclude:
localtion: "test*.go"
After having spent too much time on "why is nothing ever coming out of the filter anymore?" -- because such invalid rules makes it that nothing makes it through -- I would like to put forth that stricter filter rules parsing be implemented. A warning must at the very least be printed when the filter encounters invalid configuration primitives.
From what I can tell, this would be the place to do so: https://github.com/microsoft/sarif-tools/blob/v3.0.4/sarif/filter/general_filter.py#L85 Trying to keep the "pass through" logic for FILTER_SHORTCUTS.get(), I only came up with warts-level python of patches. Thus, it might be better that actual professional developers take a look at how to make such a patch.
Cheers.
Once upon a time, I made a typo in a filter rule (
localtioninstead oflocation) :After having spent too much time on "why is nothing ever coming out of the filter anymore?" -- because such invalid rules makes it that nothing makes it through -- I would like to put forth that stricter filter rules parsing be implemented. A warning must at the very least be printed when the filter encounters invalid configuration primitives.
From what I can tell, this would be the place to do so: https://github.com/microsoft/sarif-tools/blob/v3.0.4/sarif/filter/general_filter.py#L85 Trying to keep the "pass through" logic for
FILTER_SHORTCUTS.get(), I only came up with warts-level python of patches. Thus, it might be better that actual professional developers take a look at how to make such a patch.Cheers.