Skip to content

New Command structure - migrated from private repo #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cpeth wants to merge 2 commits into
base: main
Choose a base branch
from
Open

New Command structure - migrated from private repo #34

cpeth wants to merge 2 commits into from

Conversation

@cpeth
Copy link
Contributor

@cpeth cpeth commented Nov 18, 2025

See original PR: https://github.com/microsoft/vscode-fabric-pr/pull/92

Moved as is to new repo.

@cpeth
Copy link
Contributor Author

cpeth commented Nov 18, 2025

@wade0016 I tried out moving the new command classes to the util package but it was more work than anticipated and didn't quite feel as clean. I think we should implement this in core for now and reevaluate when we look at util package further for improvements.

@cpeth cpeth requested a review from wade0016 November 18, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wade0016 wade0016 Awaiting requested review from wade0016

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpeth