[html] completions: better handle unclosed string literals

[vbeffa]

Type: Bug

Given the code

<th><input type="che</th> with the cursor after che, typing ctrl-space and then selecting "checkbox" deletes the text after, leaving just <th><input type="checkbox.

VS Code version: Code 1.105.1 (Universal) (7d842fb, 2025-10-14T22:33:36.618Z)
OS version: Darwin x64 21.6.0
Modes:

Screen.Recording.2025-10-24.at.6.36.25.PM.mov

[vbeffa]

Note that this happens even if there is a space after "che" as in <th><input type="che </th>.

[jrieken]

That's because html configures the "editor.suggest.insertMode" to be replace

[vbeffa]

This seems to be a case of being too aggressive when it shouldn't be. This is in contrast to a very common scenario where the editor is not aggressive enough. See video. Not the best example, but I often need to replace a method call and end up having to replace/delete text after I auto-complete the new method. It would be great if the editor did it for me (in this case, to remove the arseInt after the cursor).

Screen.Recording.2025-10-30.at.4.02.56.PM.mov

[aeschli]

For the parser everything after the " is a string literal until there's a closing "
<th><input type="che </th>.
It's not easy to discover where the " is missing.

Normally what happens is that when you type ", we autoclose that with a closing "

[vbeffa]

Why not just insert ckbox" and not replace any subsequent text? Again, that's what happens with parseInt (although in that case I would argue the parser should search for the opening ( and replace everything up to that point).

Also, if there is no closing " on the current line, then it doesn't currently exist (as multi-line quotes with " aren't valid), so there's nothing to replace.