From 4f168e441e5dd2dbad2bda663e7fe6e70b3d4673 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 8 Jul 2026 11:45:28 +0000 Subject: [PATCH 1/2] Palette: Settings Hotkey accessibility improvement --- .jules/palette.md | 3 +++ SettingsWindow.xaml | 20 ++++++++++++++++---- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/.jules/palette.md b/.jules/palette.md index 7e5218ec..95ca4cf8 100644 --- a/.jules/palette.md +++ b/.jules/palette.md @@ -21,3 +21,6 @@ ## 2026-05-15 - ProgressRing Visibility Binding **Learning:** In WinUI 3, a `ProgressRing` automatically hides its visuals when `IsActive="False"`. It is not necessary to explicitly bind its `Visibility` property using a boolean-to-visibility converter unless the layout space it reserves needs to be reclaimed. **Action:** When adding simple visual feedback using a `ProgressRing` alongside a button (e.g., in a `StackPanel`), simply bind the `IsActive` property to the async command's execution state without a redundant `Visibility` binding. +## 2026-05-18 - Input Field Accessibility Linkage +**Learning:** In WinUI 3 XAML settings or forms, input fields (like `ComboBox` or `TextBox`) that are grouped under a visual `TextBlock` header lack context for screen reader users navigating directly to the inputs. +**Action:** Explicitly link interactive controls to their visual headers to properly support screen readers. Assign an `x:Name` to the descriptive `TextBlock` and set `AutomationProperties.LabeledBy="{Binding ElementName=HeaderName}"` on the interactive control. diff --git a/SettingsWindow.xaml b/SettingsWindow.xaml index c22b50b3..eef0a592 100644 --- a/SettingsWindow.xaml +++ b/SettingsWindow.xaml @@ -103,11 +103,23 @@ - + - - - + + + From 2890b081c5c9ce6ff6b6ae00c0b0eea6253c0a19 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 8 Jul 2026 11:51:18 +0000 Subject: [PATCH 2/2] Revert Hotkey LabeledBy changes and update memory instructions --- .jules/palette.md | 2 +- SettingsWindow.xaml | 20 ++++---------------- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/.jules/palette.md b/.jules/palette.md index 95ca4cf8..3c10f746 100644 --- a/.jules/palette.md +++ b/.jules/palette.md @@ -23,4 +23,4 @@ **Action:** When adding simple visual feedback using a `ProgressRing` alongside a button (e.g., in a `StackPanel`), simply bind the `IsActive` property to the async command's execution state without a redundant `Visibility` binding. ## 2026-05-18 - Input Field Accessibility Linkage **Learning:** In WinUI 3 XAML settings or forms, input fields (like `ComboBox` or `TextBox`) that are grouped under a visual `TextBlock` header lack context for screen reader users navigating directly to the inputs. -**Action:** Explicitly link interactive controls to their visual headers to properly support screen readers. Assign an `x:Name` to the descriptive `TextBlock` and set `AutomationProperties.LabeledBy="{Binding ElementName=HeaderName}"` on the interactive control. +**Action:** Explicitly link interactive controls to their visual headers to properly support screen readers. Assign an `x:Name` to the descriptive `TextBlock` and set `AutomationProperties.LabeledBy="{Binding ElementName=HeaderName}"` on the interactive control ONLY IF no per-field `AutomationProperties.Name` already exists for those controls. diff --git a/SettingsWindow.xaml b/SettingsWindow.xaml index eef0a592..c22b50b3 100644 --- a/SettingsWindow.xaml +++ b/SettingsWindow.xaml @@ -103,23 +103,11 @@ - + - - - + + +