[BUG] Heimdall API - Multifile File Upload Failure

[bfield308]

Describe the bug
The multifile upload in a single curl is failing when following the Heimdall API Documentation located at:

https://github.com/mitre/heimdall2/wiki/Heimdall-API-Documentation/#upload-evaluations-scans-via-curl

resulting in the message:

{"message":["filename must be a string","filename should not be empty"],"error":"Bad Request","statusCode":400}

To Reproduce
Steps to reproduce the behavior:

1. Create artifacts to upload in pipeline
2. Find files and associate them to their respective locations
3. Retrieve key for group
4. run curl command with multiple -F data=@$file_name*
5. error message received

Expected behavior
Should post each file with a successfull message for ID's, files, evaluationTags, groupID, etc

Desktop (please complete the following information):

• Pipeline activities with proven implementation patterns

Additional context
N/A

[Amndeep7]

I dunno how this hadn't ever come up, but I believe it is due to filename being a mandatory field (https://github.com/mitre/heimdall2/blob/master/libs/common/interfaces/evaluation/create-evaluation.interface.ts#L4). A workaround you can do for now is to provide the filename attribute, which will just be ignored.

[bfield308]

I'll test the workaround but an alternative was a quick for loop and parsing the basename from the file_path for each of the files. This retained the naming convention desired with all of the tagging (also dynamic).