From 61336337c27d8003af3f1bb9d1a3c34a8ead7099 Mon Sep 17 00:00:00 2001
From: mleem97 <52848568+mleem97@users.noreply.github.com>
Date: Mon, 17 Aug 2026 00:00:20 +0000
Subject: [PATCH] Optimize LuaServerModule queries to use O(1) game singletons

Replaced expensive FindObjectsOfType calls in LuaServerModule with O(1) NetworkMap dictionary lookups. Added defensive fallback if dictionaries are not initialized. Extracted logging out of critical section in CablePositionsPatch.
---
 .../Patches/Networking/CablePositionsPatch.cs |   8 +-
 .../Scripting/Lua/Modules/LuaServerModule.cs  | 109 +++++++++++++++---
 2 files changed, 98 insertions(+), 19 deletions(-)

diff --git a/src/GameLayer/Patches/Networking/CablePositionsPatch.cs b/src/GameLayer/Patches/Networking/CablePositionsPatch.cs
index 84c3f50c..3d793e7a 100644
--- a/src/GameLayer/Patches/Networking/CablePositionsPatch.cs
+++ b/src/GameLayer/Patches/Networking/CablePositionsPatch.cs
@@ -67,7 +67,13 @@ public static void SetBaseId(int baseId)
         }
         while (Interlocked.CompareExchange(ref _nextCableId, baseId + 1, current) != current);
 
-        MelonLogger.Msg($"[CablePatch] Cable ID counter set to {baseId + 1}");
+        try { LogBaseIdSet(baseId + 1); } catch { }
+    }
+
+    [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.NoInlining)]
+    private static void LogBaseIdSet(int newBaseId)
+    {
+        MelonLogger.Msg($"[CablePatch] Cable ID counter set to {newBaseId}");
     }
 
     public static int PeekNextId() => _nextCableId;
diff --git a/src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs b/src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs
index 17bd8abb..d458f1dd 100644
--- a/src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs
+++ b/src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs
@@ -21,27 +21,56 @@ public static void Register(Table greg, Script script, string modId)
         {
             try
             {
-                var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
+                var nm = Il2Cpp.NetworkMap.instance;
+                var servers = nm != null && nm.servers != null ? nm.servers.Values : null;
+
                 var result = new Table(script);
                 int i = 1;
-                foreach (var s in servers)
+
+                if (servers != null)
                 {
-                    try
+                    foreach (var s in servers)
                     {
-                        var info = new Table(script);
-                        info["id"] = s.ServerID ?? s.GetHashCode().ToString();
-                        info["hash"] = s.GetHashCode();
-                        info["is_on"] = s.isOn;
-                        info["is_broken"] = s.isBroken;
-                        info["server_type"] = (int)s.serverType;
-                        info["size_u"] = s.sizeInU;
-                        var pos = s.transform?.position ?? UnityEngine.Vector3.zero;
-                        info["x"] = (double)pos.x;
-                        info["y"] = (double)pos.y;
-                        info["z"] = (double)pos.z;
-                        result[i++] = info;
+                        try
+                        {
+                            var info = new Table(script);
+                            info["id"] = s.ServerID ?? s.GetHashCode().ToString();
+                            info["hash"] = s.GetHashCode();
+                            info["is_on"] = s.isOn;
+                            info["is_broken"] = s.isBroken;
+                            info["server_type"] = (int)s.serverType;
+                            info["size_u"] = s.sizeInU;
+                            var pos = s.transform?.position ?? UnityEngine.Vector3.zero;
+                            info["x"] = (double)pos.x;
+                            info["y"] = (double)pos.y;
+                            info["z"] = (double)pos.z;
+                            result[i++] = info;
+                        }
+                        catch { }
+                    }
+                }
+                else
+                {
+                    var fbServers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
+                    foreach (var s in fbServers)
+                    {
+                        try
+                        {
+                            var info = new Table(script);
+                            info["id"] = s.ServerID ?? s.GetHashCode().ToString();
+                            info["hash"] = s.GetHashCode();
+                            info["is_on"] = s.isOn;
+                            info["is_broken"] = s.isBroken;
+                            info["server_type"] = (int)s.serverType;
+                            info["size_u"] = s.sizeInU;
+                            var pos = s.transform?.position ?? UnityEngine.Vector3.zero;
+                            info["x"] = (double)pos.x;
+                            info["y"] = (double)pos.y;
+                            info["z"] = (double)pos.z;
+                            result[i++] = info;
+                        }
+                        catch { }
                     }
-                    catch { }
                 }
                 return result;
             }
@@ -80,8 +109,27 @@ public static void Register(Table greg, Script script, string modId)
         {
             try
             {
-                var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
-                foreach (var s in servers)
+                var nm = Il2Cpp.NetworkMap.instance;
+                var servers = nm != null && nm.brokenServers != null ? nm.brokenServers.Values : null;
+
+                if (servers != null)
+                {
+                    foreach (var s in servers)
+                    {
+                        try
+                        {
+                            if (s.GetHashCode() == hash && s.isBroken)
+                            {
+                                s.RepairDevice();
+                                return true;
+                            }
+                        }
+                        catch { }
+                    }
+                }
+
+                var fbServers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
+                foreach (var s in fbServers)
                 {
                     try
                     {
@@ -104,6 +152,31 @@ public static void Register(Table greg, Script script, string modId)
             try
             {
                 int repaired = 0;
+                var nm = Il2Cpp.NetworkMap.instance;
+
+                if (nm != null && nm.brokenServers != null && nm.brokenServers.Count > 0)
+                {
+                    var brokenList = new System.Collections.Generic.List<Il2Cpp.Server>();
+                    foreach (var kvp in nm.brokenServers)
+                    {
+                        brokenList.Add(kvp.Value);
+                    }
+
+                    foreach (var s in brokenList)
+                    {
+                        try
+                        {
+                            if (s.isBroken)
+                            {
+                                s.RepairDevice();
+                                repaired++;
+                            }
+                        }
+                        catch { }
+                    }
+                    return repaired;
+                }
+
                 var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
                 foreach (var s in servers)
                 {