From 05c7af9406d718d5a393ef22c1b56c4bae5ce95b Mon Sep 17 00:00:00 2001 From: mlevkov Date: Sun, 5 Jul 2026 17:03:10 -0700 Subject: [PATCH] fix(ci): correct release binary name to iggy_sample First-ever exercise of the tag-triggered release pipeline surfaced a latent bug: BINARY_NAME was iggy-sample (hyphen) but cargo builds iggy_sample (underscore) from the crate name, so every platform's Package step failed on the cp and no release was created. All five release builds compiled successfully otherwise. Also untracks .claude/settings.local.json: the file has been listed in .gitignore since the initial public release but was accidentally committed then, and gitignore does not apply to tracked files - local tool settings do not belong in the repository. --- .claude/settings.local.json | 46 ----------------------------------- .github/workflows/release.yml | 4 ++- 2 files changed, 3 insertions(+), 47 deletions(-) delete mode 100644 .claude/settings.local.json diff --git a/.claude/settings.local.json b/.claude/settings.local.json deleted file mode 100644 index c19bf0c..0000000 --- a/.claude/settings.local.json +++ /dev/null @@ -1,46 +0,0 @@ -{ - "permissions": { - "allow": [ - "WebSearch", - "WebFetch(domain:github.com)", - "WebFetch(domain:crates.io)", - "WebFetch(domain:docs.rs)", - "WebFetch(domain:raw.githubusercontent.com)", - "Bash(cargo check:*)", - "Bash(cargo test:*)", - "Bash(cargo fmt:*)", - "Bash(cargo clippy:*)", - "WebFetch(domain:hub.docker.com)", - "Bash(cargo search:*)", - "Bash(cargo update:*)", - "Bash(docker pull apache/iggy:server-0.5.0)", - "Bash(docker pull:*)", - "WebFetch(domain:iggy.apache.org)", - "Bash(docker run:*)", - "Bash(cargo doc:*)", - "Bash(cargo tree:*)", - "Bash(cargo build:*)", - "Bash(rustc --version:*)", - "Bash(cargo --version:*)", - "Bash(find:*)", - "Bash(RUST_LOG=debug cargo test:*)", - "Bash(RUST_BACKTRACE=1 RUST_LOG=iggy_sample=debug,integration_tests=debug cargo test:*)", - "Bash(cargo fuzz:*)", - "Bash(rustup run nightly rustc:*)", - "Bash(cargo +nightly fuzz:*)", - "Bash(cargo +nightly install:*)", - "Bash(cargo deny check:*)", - "Bash(for:*)", - "Bash(do echo \"=== $file ===\" grep -n '#\\[cfg(test)\\]' \"$file\")", - "Bash(git config:*)", - "Bash(git check-ignore:*)", - "Bash(cargo metadata:*)", - "Bash(cargo publish:*)", - "Bash(cat:*)", - "Bash(test:*)", - "Bash(cargo package:*)" - ], - "deny": [], - "ask": [] - } -} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d97d6b4..c2cd486 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,7 +13,9 @@ on: env: CARGO_TERM_COLOR: always - BINARY_NAME: iggy-sample + # Must match the crate name in Cargo.toml (cargo names the binary with + # the underscore, not a hyphen) + BINARY_NAME: iggy_sample permissions: contents: write