From 2ed5873be9e76faf9b14e77284bc1a175c14aa9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=B5=9C=EC=A4=80=ED=98=81?= <160326131+Jun3671@users.noreply.github.com> Date: Sun, 20 Sep 2026 02:10:27 +0900 Subject: [PATCH] =?UTF-8?q?[refactor]=20=EC=9E=A5=EC=86=8C=20=ED=88=AC?= =?UTF-8?q?=ED=91=9C=20API=20=EC=9D=91=EB=8B=B5=EC=97=90=EC=84=9C=20?= =?UTF-8?q?=EB=AF=B8=EC=82=AC=EC=9A=A9=20isConfirmed=20=ED=95=84=EB=93=9C?= =?UTF-8?q?=20=EC=A0=9C=EA=B1=B0=20(#136)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [refactor #135] 장소 투표 API 응답에서 미사용 isConfirmed 필드 제거 --- .../MoiveBE/domain/vote/controller/VoteController.java | 7 +++---- .../com/moive/MoiveBE/domain/vote/service/VoteService.java | 6 ++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/moive/MoiveBE/domain/vote/controller/VoteController.java b/src/main/java/com/moive/MoiveBE/domain/vote/controller/VoteController.java index 1757d6d..4af6b21 100644 --- a/src/main/java/com/moive/MoiveBE/domain/vote/controller/VoteController.java +++ b/src/main/java/com/moive/MoiveBE/domain/vote/controller/VoteController.java @@ -2,7 +2,6 @@ import com.moive.MoiveBE.domain.vote.dto.DateVoteResultResponse; import com.moive.MoiveBE.domain.vote.dto.PlaceVoteRequest; -import com.moive.MoiveBE.domain.vote.dto.PlaceVoteResponse; import com.moive.MoiveBE.domain.vote.dto.PlaceVoteResultResponse; import com.moive.MoiveBE.domain.vote.service.VoteService; import com.moive.MoiveBE.global.common.BaseResponse; @@ -43,13 +42,13 @@ public BaseResponse getMeetingScheduleVoteResult ( description = "추천 장소들에 대한 투표를 진행합니다." ) @PostMapping("/place-votes") - public BaseResponse createMeetingPlaceVote ( + public BaseResponse createMeetingPlaceVote ( @AuthenticationPrincipal Long userId, @PathVariable Long meetingId, @Valid @RequestBody PlaceVoteRequest request ) { - boolean isConfirmed = voteService.createPlaceVote(userId, meetingId, request); - return BaseResponse.success(PlaceVoteResponse.of(isConfirmed)); + voteService.createPlaceVote(userId, meetingId, request); + return BaseResponse.success(null); } @Operation( diff --git a/src/main/java/com/moive/MoiveBE/domain/vote/service/VoteService.java b/src/main/java/com/moive/MoiveBE/domain/vote/service/VoteService.java index 3ee0996..5f3e1bd 100644 --- a/src/main/java/com/moive/MoiveBE/domain/vote/service/VoteService.java +++ b/src/main/java/com/moive/MoiveBE/domain/vote/service/VoteService.java @@ -160,7 +160,7 @@ private DateVoteResultResponse.Candidate toCandidate(DateVoteSummary aggregate) * 장소 투표 생성 */ @Transactional - public boolean createPlaceVote(Long userId, Long meetingId, PlaceVoteRequest request) { + public void createPlaceVote(Long userId, Long meetingId, PlaceVoteRequest request) { // 모임 조회 Meeting meeting = meetingRepository.findById(meetingId) .orElseThrow(() -> new CustomException(MEETING_NOT_FOUND)); @@ -219,11 +219,9 @@ public boolean createPlaceVote(Long userId, Long meetingId, PlaceVoteRequest req long voterCnt = placeVoteRepository.countDistinctVoters(meetingId); long eligibleCnt = participantRepository.countByMeetingIdAndLeftAtIsNullAndStateNot( meetingId, ParticipantState.NEW_RESTRICTED); - boolean isConfirmed = voterCnt == eligibleCnt; - if (isConfirmed) { + if (voterCnt == eligibleCnt) { confirmMeetingPlace(meeting); } - return isConfirmed; } // 모임 장소 확정