Skip to content

[CI] - Linting Failure on dev => main Merge #58

Description

@monozoide

👋 Context

The lint workflow fails during merge from dev to main with Ruff detecting code quality violations.

🎯 Goals

Resolve linting failures blocking the CI/CD pipeline and ensure code quality standards are met before merge.

📂 Category

  • Workflow GitHub Actions

✅ Expected Behavior

The lint workflow should complete successfully without Ruff errors when merging to main.

❌ Current Behavior

The ruff check . step fails with exit code 1, reporting 28 code quality violations:

  • 4 f-strings without placeholders (F541)
  • 15 unused imports (F401)
  • 3 assigned variables never used (F841)
  • 2 module-level imports not at top (E402)
  • 4 other violations

Ruff indicates 20 are auto-fixable with --fix flag.

📍 Context

  • Workflow file: .github/workflows/mls-ci.yml
  • Failed step: lint job (line 123-131)
  • Branch: dev => main (pull/57/merge)
  • Python: 3.11.13

📋 Logs / Error Traces

Found 28 errors.
[*] 20 fixable with the `--fix` option (5 hidden fixes can be enabled with the `--unsafe-fixes` option).
##[error]Process completed with exit code 1.

Affected files:

  • bin/maillogsentinel_setup.py
  • lib/maillogsentinel/parser.py
  • lib/maillogsentinel/sql_exporter.py
  • lib/maillogsentinel/sql_importer.py
  • tests/bin/test_maillogsentinel_setup.py
  • tests/lib/maillogsentinel/test_log_utils.py
  • tests/lib/maillogsentinel/test_progress.py
  • tests/lib/maillogsentinel/test_report.py
  • tests/lib/maillogsentinel/test_sql_exporter.py

Full logs:


☑️ Checklist

  • Verified no similar issue exists
  • Included relevant logs and error traces
  • Tested against latest code version

Metadata

Metadata

Assignees

Labels

choreFor maintenance/infrastructure tasksciImprovement and/or corrections to test / CI workflowsmetaFor: changes to GitHub infrastructure (.github/, templates, workflows)

Projects

Status
Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions