From 77eca88727a14915f0498c8fd02b79ed68fd93cf Mon Sep 17 00:00:00 2001 From: Daisuke Nishimatsu Date: Sun, 19 Jul 2026 17:18:05 +1000 Subject: [PATCH 1/2] Use explicit Boost targets in warehouse_ros_sqlite This upstreams a RoboStack build fix from patch/ros-rolling-warehouse-ros-sqlite.patch. The best-guess rationale is that warehouse_ros_sqlite only needs Boost headers for the library itself and filesystem/thread for the tests. Linking the explicit Boost targets avoids relying on the aggregate ${Boost_LIBRARIES} variable and keeps the target dependencies precise for modern CMake toolchains. Signed-off-by: Tobias Fischer --- CMakeLists.txt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b8d7279..28ee31f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -35,6 +35,7 @@ set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 14) target_include_directories(${PROJECT_NAME} SYSTEM PUBLIC ${Boost_INCLUDE_DIRS}) target_link_libraries(${PROJECT_NAME} PUBLIC + Boost::headers class_loader::class_loader rclcpp::rclcpp warehouse_ros::warehouse_ros @@ -64,12 +65,10 @@ if(BUILD_TESTING) target_link_libraries(SchemaVersion ${PROJECT_NAME}) ament_add_gtest(TestLoader test/TestLoader.cpp) - target_link_libraries(TestLoader ${PROJECT_NAME}) - target_link_libraries(TestLoader ${Boost_LIBRARIES}) + target_link_libraries(TestLoader ${PROJECT_NAME} Boost::filesystem Boost::thread) ament_add_gtest(BusyHandler test/BusyHandler.cpp) - target_link_libraries(BusyHandler ${PROJECT_NAME}) - target_link_libraries(BusyHandler ${Boost_LIBRARIES}) + target_link_libraries(BusyHandler ${PROJECT_NAME} Boost::filesystem Boost::thread) find_package(ament_lint_auto REQUIRED) list(APPEND AMENT_LINT_AUTO_EXCLUDE From 7e8bce6aa29825039ab001775823e8724de8f122 Mon Sep 17 00:00:00 2001 From: Tobias Fischer Date: Sun, 19 Jul 2026 19:55:40 +1000 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Robert Haschke --- CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 28ee31f..2c08da9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -33,7 +33,6 @@ target_include_directories(${PROJECT_NAME} PUBLIC "$