[Typescript] Improving types

[jamesst20]

Hi,

I have written types for myself to improve Svelecte usage in my own wrapper.

I though maybe I could share so you could see yourself if maybe this would be a great addition to be embedded into Svelecte.

REPL

[mskocik]

I am not against it, but I don't really know what should be done.

[jamesst20]

@mskocik

I had forgotten Svelecte was written in plain JS.

Right now, based on your JSDoc (comments like /** @type {string} */) when you run pnpm run package it generates d.ts files that provide typescript typings.

I gave a try and wrote the equivalent under jsdoc

types-jsdoc.txt

If applied properly, it should output proper d.ts file, right? I have never used jsdoc before

Not sure how you would tell that there are generics type in the component itself? Do you need to add an extra top declaration like

/**
  * @template {ItemType<Opt, TKey, VKey>} Opt
  * @template {boolean} M
  * @template {boolean} VObj
  * @template {GenericKeyType<Opt>} TKey
  * @template {GenericKeyType<Opt>} VKey
  */

?

[mskocik]

I am open to this enhancement.

I am not sure your JSDoc types are correct, but I am not an expert in JSDOc 🤷 Have you tried it on the codebase itself?