MSYS_NO_PATHCONV=1 breaks /usr/bin/start

[robario]

Description / Steps to reproduce the issue

1. $ export MSYS_NO_PATHCONV=1
2. $ /usr/bin/start explorer.exe

Expected behavior

$ /usr/bin/start explorer.exe

# explorer.exe runs correctly.

Actual behavior

$ /usr/bin/start explorer.exe
Microsoft Windows [Version 10.0.22631.5909]
(c) Microsoft Corporation. All rights reserved.

C:\>

Verification

• I have verified that my MSYS2 is up-to-date before submitting the report (see https://www.msys2.org/docs/updating/)

Windows Version

MINGW64_NT-10.0-22631

Are you willing to submit a PR?

No

[robario]

I don't know the best way to do this, but the following will solve it:

if ((${MSYS_NO_PATHCONV:-0}))
then
  cmd='cmd /c'
else
  cmd='cmd //c'
fi
$cmd start "${@//&/^&}"

[robario]

Note: There are other similar codes.
https://github.com/search?q=repo%3Amsys2%2FMSYS2-packages++%22cmd+%2F%2F%22&type=code

[robario]

These seem to behave the same.

• MSYS_NO_PATHCONV=1
• MSYS_NO_PATHCONV=0
• MSYS_NO_PATHCONV=''

So, based on the current implementation, the following is better:

if [[ ${MSYS_NO_PATHCONV+'effective'} ]]
then
  cmd='cmd /c'
else
  cmd='cmd //c'
fi
$cmd start "${@//&/^&}"