Custom modules do nothing

[veronoicc]

Description / 问题描述

Adding a custom module under /settings/personalize does nothing, at least not visually.

Steps to Reproduce / 复现步骤

1. Go to /settings/personalize
2. Under "Modules", add a new Module
3. Under "Templates", select a Template to change and select a page, and add the just created Module there
4. Going to a contact and checking that page does not show the new custom Module, not even after re-applying the Template on the contact

Expected Behavior / 期望行为

The new Module is shown under the Page it was assigned to

Actual Behavior / 实际行为

The new Module is not shown anywhere.

Environment / 环境信息

No response

Additional Context / 补充信息

Additionally, i could not really find any documentation on how custom Modules work. As in how does one select the type (for example dropdown with a select range of items, free text or a number input). If that is how it is supposed to work, then it should be possible to select and configure the custom modules too.

[veronoicc]

I also just saw in doc/features/contacts.md it talks about some "View Mode" and "Edit Mode", i could however not find if this is still a thing and if so, how to switch between them, as you can just edit all fields in the "Full view" of a contact.

[naiba]

Thanks for the report. I can confirm the current behavior is unclear, but before implementing this we need to define what a "custom module" is supposed to render as.

Could you confirm the expected minimum behavior?

1. Should a custom module initially be just a titled/empty block that appears on the assigned contact page?
2. Or should custom modules support configurable fields, such as text, number, select/dropdown, etc.?
3. If fields are expected, should the data be stored per contact as arbitrary key/value fields?

Without that product definition, any implementation would be guessing the schema and UI behavior.

[veronoicc]

I think custom modules should basically be like any normal module, but you can specify on your own what kind of data they hold, examples being Files as in Photos or Documents, simple key-value Pairs like in Notes (where you also specify what type the key and value is, so for example you could say the key is of type text and with name Title and the value is also Text with name Content, then you'd have basically replicated the Notes field, but also supporting like a preconfigured list of items for key and/or value like in Quick Facts). Basically in a custom module you can add fields, and those fields can have one of a few different types like the ones i just specified and possibly more. For the actual data i do think they should be stored as key/value fields, obviously with distinction per custom module. This could then also resolve the last open question in #161 because if you made a custom module that just has key and value both as text, you basically have a custom key/value store, as was asked there.