Skip to content

INTERNAL: Clarify elem_item comments in item_base.h#972

Merged
jhpark816 merged 1 commit into
naver:developfrom
zhy2on:internal/clarify-elem-item-comments
May 18, 2026
Merged

INTERNAL: Clarify elem_item comments in item_base.h#972
jhpark816 merged 1 commit into
naver:developfrom
zhy2on:internal/clarify-elem-item-comments

Conversation

@zhy2on
Copy link
Copy Markdown
Collaborator

@zhy2on zhy2on commented May 18, 2026

🔗 Related Issue

⌨️ What I did

item_base.helem_item 구조체 멤버 주석을 정리:

  • map, btreenbytes 주석이 "total size of the data"로 되어 있어, data[] 전체 크기로 오해할 수 있었습니다.
    • 실제로는 data[] 내 value 부분의 크기만을 의미하므로 "size of the value"로 수정했습니다.
      (mapdata[]는 field+value, btreedata[]는 bkey+eflag+value)
  • in data[], (in bytes) 등 불필요한 중복 표현 제거
  • /**< Doxygen 스타일 주석을 /* 로 통일

@zhy2on zhy2on requested a review from jhpark816 May 18, 2026 07:21
@zhy2on zhy2on self-assigned this May 18, 2026
- nbytes/nfield: correct comments to reflect actual meaning
  (e.g. "total size of the data" → "size of the value")
- remove redundant expressions such as "in data[]" and "(in bytes)"
- unify /**< Doxygen-style comments to /*
@zhy2on zhy2on force-pushed the internal/clarify-elem-item-comments branch from 4b5931b to f877419 Compare May 18, 2026 07:25
@zhy2on zhy2on changed the title INTERNAL: Clarify and unify comments in elem_item structs (item_base.h) INTERNAL: Clarify elem_item comments in item_base.h May 18, 2026
@jhpark816 jhpark816 merged commit 9f93984 into naver:develop May 18, 2026
1 check passed
@zhy2on zhy2on deleted the internal/clarify-elem-item-comments branch May 18, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants