Dot repeat doesn't call sade function

[joshtch]

From before:

�function! SadeAppend()
    normal! `>
    if 'g:sade#Repeating'
        normal! .
    else
        call feedkeys("�\<esc>a", 'n')
    endif
endfunction
function! SadeInsert()
    normal! `<
    if 'g:sade#Repeating'
        normal! .
    else
        call feedkeys("�\<esc>i", 'n')
    endif
endfunction
call sade#Func('(', 'SadeInsert')
call sade#Func(')', 'SadeAppend')

When I press the dot operator it performs the last insert operation at the current location without calling the function.

[neitanod]

I think the sade#Repeating value is a bit confusing. Your function will be called with the dot command, and you don't really need to look at that value most of the time. Just do this:

" remember that the function is always called from visual mode,
" no matter if you used a motion, it gets translated to a visual 
" selection

function! SadeAppend()
    exe "normal! \<esc>`>"
    call feedkeys('a', 'n')
endfunction

function! SadeInsert()
    exe "normal! \<esc>`<"
    call feedkeys('i', 'n')
endfunction

call sade#Func('(', 'SadeInsert')
call sade#Func(')', 'SadeAppend')

[joshtch]

Okay, then I guess this plugin just doesn't do what I was hoping it did. I'm trying to create an operator that takes a textobject and enters insert mode either before or after the object, and, crucially, with the ability to repeat. For instance, gUip is a built-in operation that set all letters in a paragraph to uppercase. After using it, you can use the dot operator to make all letters in a different paragraph all uppercase also. In the case of my operators, you could insert a certain text at the start or end of a given text object, and then use the dot operator to repeat the text in front of another object of the same type. Tim Pope's surround.vim can do repeats like this (with repeat.vim), except of course it inserts text on both sides of the object.

[neitanod]

Looks like what you are trying to do is perform a complex command that is in part formed by the call to the function and then completed with additional input.

The problem here is that feedkeys puts the "i" at the end of the keyboard buffer, and so it's not part of the function that is running. The function ends first, and only then the insert command starts. The function does not get called again because the call to SadeInsert is no longer the last typed command.
I'm not sure it is feasible, but if you really want this functionality repeatable, you should dispose of feedkeys, and try a "getchar() in a loop" instead. Use it to capture all the input (and insert every char one by one so it does not feel like the input has been hijacked) and store it in a variable to be reused in future calls.
Then, you could use sade#Repeating to know if you have to use the getchar() loop again (when not repeating) or just use the stored input from before (when repeating).

[neitanod]

In fact what you were hoping is what I want it to do, and it does in most cases, but feedkeys breaks out of the function. It's easier when the text you insert is not interactive.
Anyway, I believe that Tim Pope's Surround does something along the lines of getchar(). I think I could add an utility function to sade to "simulate" insert mode and capture all typed chars without leaving the sade mapped function.

[joshtch]

Hm yeah that sounds about right. I remember in my research I saw a sort of workaround to get back to the function after inserting, but it didn't fix the dot operator issue. It used an autocommand sort of like this:

function! Foo()
    " Preamble stuff here
    augroup Baz
        autocmd!
        autocmd InsertLeave <buffer> call Bar()
        autocmd WinLeave,BufLeave <buffer> autocmd!
    augroup END
    call feedkeys("i", 'n')
endfunction

function! Bar()
    autocmd! Baz
    " Postamble stuff here
endfunction

Here's a thread that talks about modifying b:changedtick to make vim think the insert command happened within the function. I'm not sure if it will help any, though, since that thread was about custom textobjects, not operators, and it was in the context of the repeat.vim plugin.

[joshtch]

Gosh, I'm an idiot. I get what you mean now. feedkeys overwrites the command to be run by the dot operator.

[neitanod]

The problem with the approach I'm suggesting (the getchar()-in-a-loop) is that it will not use the insert mode mappings that the user have. For instance, I have jk mapped to Esc, but I will have to type the real Esc to get out of the loop and finish the insertion.

[neitanod]

Tim Pope's Surround uses getchar only once, not in a loop. This case is harder to deal with.

[neitanod]

This problem is not with sade itself, but with the way Vim works. It does not give you an easy way of grouping future commands together for the dot command to repeat. I will try to figure out a workaround, but meanwhile I will close the issue.

[joshtch]

That's reasonable enough. I made a post on Vim's bug tracker about this, maybe we'll get a fix upstream. Thanks for your help!

[neitanod]

This version is much simpler because it does not need additional input, and might be enough for some of your use cases. You must have the text you want to paste in your yank registry already, but this one IS repeatable.

call sade#Func("(p","SadePasteBefore")
call sade#Func(")p","SadePasteAfter")

func! SadePasteAfter()
  exe "norm! \<esc>`>p"
endfun

func! SadePasteBefore()
  exe "norm! \<esc>`<P"
endfun

Or directly:

call sade#Map("(p","\<esc>`<P")
call sade#Map(")p","\<esc>`>p")

[joshtch]

Hi Sebastián, thanks for the suggestion. Are those commands working for you though? They aren't for me. Instead it just pastes the same nonsense text no matter what I do. I checked my registers (:registers) and the text in question isn't in any of them. Whenever I run either of the motions (regardless of which method they were defined with) the same text reappears in the unnamed register.

I tried using a bare vim config also. Here was the entirety of my .vim directory:

+---.vim
|   +---autoload
|       \---sade.vim
|   +---doc
|       \---vim-sade.txt
\---README.md

And I started it with vim -u test.vim, where test.vim looks like:

call sade#Map(")p","\<esc>`>p")

Instead of printing something though, this time it leaves the following in the command area:

:call sade#HookNormal(')p')g@iw

where i@ can be interchanged with any motion or text object. When I press return I get E488: Trailing characters.

[neitanod]

Wow, thanks for your contributions!
It's a shame that I'm just about to go on a quick trip and cannot test a
clean config right now, but I didn't want to leave you without an answer,
and I will definitely test this on monday. Thanks!

Sebastián Grignoli

2014-03-07 22:45 GMT-03:00 joshtch notifications@github.com:

Hi Sebastián, thanks for the suggestion. Are those commands working for
you? They aren't for me. Instead it just pastes the same nonsense text no
matter what I do. I checked my registers (:registers) and the text in
question isn't in any of them. Whenever I run either of the motions
(regardless of which method they were defined with) the same text reappears
in the unnamed register.

I tried using a bare vim config also. Here was the entirety of my .vim
directory:

+---.vim
| +---autoload
| ---sade.vim
| +---doc
| ---vim-sade.txt
---README.md

And I started it with vim -u test.vim, where test.vim looks like:

call sade#Map(")p","`>p")

Instead of printing something though, this time it leaves the following in
the command area:

:call sade#HookNormal(')p')g@iw

where i@ can be interchanged with any motion or text object. When I press
return I get E488: Trailing characters.

Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-37085367
.

[neitanod]

Do you have "set nocompatible" in your minimalist configuration?