[LegacyForge plugin] Bug: Non-Minecraft code has been obfuscated.

[187J3X1-114514]

I'm trying to create a multi-loader, multi-Minecraft version project, but I'm encountering a strange issue:

In my project at common/src/main/java/io/homo/superresolution/core/graphics/impl/framebuffer/IFrameBuffer.java,
this is a framebuffer interface containing a method: void setClearColor(float red, float green, float blue, float alpha).
When running Minecraft in the development environment, the entire project works fine.
However, when I run Minecraft with the built mod file (production environment), I get:

java.lang.NoSuchMethodError: 'void io.homo.superresolution.core.graphics.impl.framebuffer.IFrameBuffer.setClearColor(float, float, float, float)'
	at io.homo.superresolution.common.minecraft.HandRenderTarget.getHandRenderTarget(HandRenderTarget.java:15) ~[superresolution-forge-1.20.1-0.8.0-alpha.1.jar%23161!/:?] {re:classloading}
	at io.homo.superresolution.common.minecraft.MinecraftRenderTargetType.lambda$static$6(MinecraftRenderTargetType.java:16) ~[superresolution-forge-1.20.1-0.8.0-alpha.1.jar%23161!/:?] {re:classloading}
	at io.homo.superresolution.common.minecraft.MinecraftRenderTargetType.get(MinecraftRenderTargetType.java:25) ~[superresolution-forge-1.20.1-0.8.0-alpha.1.jar%23161!/:?] {re:classloading}
	at io.homo.superresolution.common.minecraft.MinecraftRenderHandle.updateRenderTarget(MinecraftRenderHandle.java:118) ~[superresolution-forge-1.20.1-0.8.0-alpha.1.jar%23161!/:?] {re:mixin,re:classloading}
	at io.homo.superresolution.common.minecraft.MinecraftRenderHandle.onRenderWorldBegin(MinecraftRenderHandle.java:165) ~[superresolution-forge-1.20.1-0.8.0-alpha.1.jar%23161!/:?] {re:mixin,re:classloading}
	at net.minecraft.client.renderer.GameRenderer.handler$zzb000$onRenderWorldBegin(GameRenderer.java:1616) ~[client-1.20.1-20230612.114412-srg.jar%23162!/:?] 

Later, I decompiled the built mod file and discovered that the setClearColor method was incorrectly obfuscated into void method_1236(float var1, float var2, float var3, float var4).
I then found that the Fabric-built mod also had this issue, confirming that the problem likely lies in the obfuscation of the common module.

I suspect this might be related to com.mojang.blaze3d.pipeline.RenderTarget's void setClearColor(float red, float green, float blue, float alpha) method,
because common/src/main/java/io/homo/superresolution/common/minecraft/LegacyStorageFrameBuffer.java implements IFrameBuffer while also extending RenderTarget.
As a test, I renamed the setClearColor method to _setClearColor_, and this build worked without issues.
Therefore, I believe the problem may stem from the legacyForge plugin (used in the common module).

Here is the pre-renaming IFrameBuffer.class, named IFrameBufferB.class
Here is the renamed IFrameBuffer.class, named IFrameBufferA.class

classes.zip

This is my project:

test.zip

[shartte]

I'd say this is working as intended.
If you actually introduce this interface into a class-hierarchy with classes that do require re-mapping, your super-interfaces will be subject to remapping too, since that is required to not break method overrides.

edit: To do what you are doing, you must 100% ensure that your methods NEVER name-clash with obfuscated methods in the hierarchy

[187J3X1-114514]

Thank you for your response.

Interestingly, this issue doesn't occur when I use ArchitecturyLoom. It seems to only obfuscate the super.setClearColor(red, green, blue, alpha) call. Here is my project repository link when using ArchitecturyLoom.
But at this point, I've moved on and renamed it to setClearColorRGBA :)

[shartte]

Thank you for your response.

Interestingly, this issue doesn't occur when I use ArchitecturyLoom. It seems to only obfuscate the super.setClearColor(red, green, blue, alpha) call. Here is my project repository link when using ArchitecturyLoom. But at this point, I've moved on and renamed it to setClearColorRGBA :)

I don't see how that could be correct since your subclass then either does not override the Vanilla method or your own interfaces method in production... (Unless Archloom copies your implementation method, which I doubt)

[187J3X1-114514]

After decompiling the mod files built with ArchLoom, I discovered:

ArchLoom not only obfuscated IFrameBuffer.setClearColor, but also renamed the calls to IFrameBuffer.setClearColor in HandRenderTarget to match the obfuscated method. However, LegacyForge doesn’t seem to do this. Although the obfuscation of IFrameBuffer.setClearColor wasn’t my desired outcome, ArchLoom appears to consistently rename related calls during obfuscation. I’m not certain whether ArchLoom’s or LegacyForge’s behavior is correct, but based on the results, ArchLoom's approach seems logically correct.

Here are the class files compiled with ArchLoom:

archloom.zip

In LegacyStorageFrameBuffer, HandRenderTarget, and IFrameBuffer, the setClearColor method is obfuscated.

Here are the class files compiled with LegacyForge:

legacyFg.zip

In LegacyStorageFrameBuffer and IFrameBuffer, setClearColor is obfuscated, but HandRenderTarget remains unchanged.