From b48f8c5964f6934897637b157049ebb1b90fe74b Mon Sep 17 00:00:00 2001
From: Marcel Klehr <mklehr@gmx.net>
Date: Tue, 25 Aug 2026 09:41:30 +0200
Subject: [PATCH 1/4] fix: Upgrade node version

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
---
 lib/Migration/InstallDeps.php | 2 +-
 package.json                  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/Migration/InstallDeps.php b/lib/Migration/InstallDeps.php
index ed8ed084e..4de8a32a7 100644
--- a/lib/Migration/InstallDeps.php
+++ b/lib/Migration/InstallDeps.php
@@ -34,7 +34,7 @@
 use Psr\Log\LoggerInterface;
 
 final class InstallDeps implements IRepairStep {
-	public const NODE_VERSION = 'v20.9.0';
+	public const NODE_VERSION = 'v24.19.0';
 	public const NODE_SERVER_OFFICIAL = 'https://nodejs.org/dist/';
 	public const NODE_SERVER_UNOFFICIAL = 'https://unofficial-builds.nodejs.org/download/release/';
 
diff --git a/package.json b/package.json
index 5899ac484..d2ee545a3 100644
--- a/package.json
+++ b/package.json
@@ -63,8 +63,8 @@
     "vue": "^2.7.14"
   },
   "engines": {
-    "node": "20.x",
-    "npm": "10.x"
+    "node": "24.x",
+    "npm": "11.x"
   },
   "browserslist": [
     "extends @nextcloud/browserslist-config"

From f34b77f67695e5776044533cffc736e53ab57d93 Mon Sep 17 00:00:00 2001
From: Marcel Klehr <mklehr@gmx.net>
Date: Tue, 25 Aug 2026 09:51:27 +0200
Subject: [PATCH 2/4] fix(ci): Fix psalm issues

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
---
 lib/BackgroundJobs/ClusterFacesJob.php | 2 +-
 psalm-baseline.xml                     | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/BackgroundJobs/ClusterFacesJob.php b/lib/BackgroundJobs/ClusterFacesJob.php
index a8e78adfc..81908657d 100644
--- a/lib/BackgroundJobs/ClusterFacesJob.php
+++ b/lib/BackgroundJobs/ClusterFacesJob.php
@@ -36,7 +36,7 @@ protected function run($argument): void {
 		$userId = (string)$argument['userId'];
 		try {
 			$iniValue = ini_get('memory_limit');
-			if ($iniValue === false) {
+			if ($iniValue === false || $iniValue === '') {
 				$batchSize = 10_000;
 			} else {
 				$memoryBytes = ini_parse_quantity($iniValue);
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
index ca80bd71b..3cbe274bb 100644
--- a/psalm-baseline.xml
+++ b/psalm-baseline.xml
@@ -13,6 +13,11 @@
       <code><![CDATA[$jobClass === static::class]]></code>
     </TypeDoesNotContainType>
   </file>
+  <file src="lib/BackgroundJobs/ClusterFacesJob.php">
+    <RedundantCastGivenDocblockType>
+      <code><![CDATA[(string)$argument['userId']]]></code>
+    </RedundantCastGivenDocblockType>
+  </file>
   <file src="lib/Classifiers/Classifier.php">
     <MixedAssignment>
       <code><![CDATA[$results]]></code>
@@ -960,6 +965,9 @@
     </PossiblyFalseArgument>
   </file>
   <file src="lib/Service/FsActionService.php">
+    <RedundantCastGivenDocblockType>
+      <code><![CDATA[(string)$userId]]></code>
+    </RedundantCastGivenDocblockType>
     <UndefinedClass>
       <code><![CDATA[$e]]></code>
       <code><![CDATA[NoUserException]]></code>

From 372662ac3919923f145cea7fc443295cc94e7a70 Mon Sep 17 00:00:00 2001
From: Marcel Klehr <mklehr@gmx.net>
Date: Tue, 25 Aug 2026 10:38:51 +0200
Subject: [PATCH 3/4] fix(nodejs): Downgrade to node v22

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
---
 lib/Migration/InstallDeps.php | 2 +-
 package.json                  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/Migration/InstallDeps.php b/lib/Migration/InstallDeps.php
index 4de8a32a7..d93efddfb 100644
--- a/lib/Migration/InstallDeps.php
+++ b/lib/Migration/InstallDeps.php
@@ -34,7 +34,7 @@
 use Psr\Log\LoggerInterface;
 
 final class InstallDeps implements IRepairStep {
-	public const NODE_VERSION = 'v24.19.0';
+	public const NODE_VERSION = 'v22.23.2';
 	public const NODE_SERVER_OFFICIAL = 'https://nodejs.org/dist/';
 	public const NODE_SERVER_UNOFFICIAL = 'https://unofficial-builds.nodejs.org/download/release/';
 
diff --git a/package.json b/package.json
index d2ee545a3..415721b8e 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,7 @@
     "vue": "^2.7.14"
   },
   "engines": {
-    "node": "24.x",
+    "node": "22.x",
     "npm": "11.x"
   },
   "browserslist": [

From 513eca82f3b500362d148893268e9d8140109d2b Mon Sep 17 00:00:00 2001
From: Marcel Klehr <mklehr@gmx.net>
Date: Wed, 26 Aug 2026 10:15:07 +0200
Subject: [PATCH 4/4] fix(ci): Test against stable34

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
---
 .github/workflows/full-run-test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/full-run-test.yml b/.github/workflows/full-run-test.yml
index 902bea81b..962d2bf57 100644
--- a/.github/workflows/full-run-test.yml
+++ b/.github/workflows/full-run-test.yml
@@ -39,7 +39,7 @@ jobs:
         movinet-enabled: ['true']
         include:
           # test pure-js once
-          - server-versions: master
+          - server-versions: stable34
             databases: sqlite
             php-versions: 8.2
             pure-js-mode: true