fix(encryption): keep the encryption_enabled app config untyped

decrypt-all wrote core/encryption_enabled through the typed app config
while every other accessor on this branch - Manager::isEnabled(),
encryption:enable, encryption:disable and the provisioning API - reads
and writes it as the string "yes"/"no". The first decrypt-all therefore
switched the stored type to boolean, after which encryption:enable threw
an AppConfigTypeConflictException and isEnabled() no longer recognised
the value.

Assisted-by: ClaudeCode:claude-opus-5

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: susnux

core/Command/Encryption/DecryptAll.php

@@ -9,7 +9,6 @@
 namespace OC\Core\Command\Encryption;
 
 use OCP\App\IAppManager;
-use OCP\IAppConfig;
 use OCP\IConfig;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\QuestionHelper;
@@ -25,7 +24,6 @@ class DecryptAll extends Command {
 	public function __construct(
 		protected IAppManager $appManager,
 		protected IConfig $config,
-		protected IAppConfig $appConfig,
 		protected \OC\Encryption\DecryptAll $decryptAll,
 		protected QuestionHelper $questionHelper,
 	) {
@@ -89,11 +87,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			return 1;
 		}
 
-		$originallyEnabled = $this->appConfig->getValueBool('core', 'encryption_enabled');
+		$originallyEnabled = $this->config->getAppValue('core', 'encryption_enabled', 'no') === 'yes';
 		try {
 			if ($originallyEnabled) {
 				$output->write('Disable server side encryption... ');
-				$this->appConfig->setValueBool('core', 'encryption_enabled', false);
+				$this->config->setAppValue('core', 'encryption_enabled', 'no');
 				$output->writeln('done.');
 			} else {
 				$output->writeln('Server side encryption not enabled. Nothing to do.');
@@ -121,26 +119,26 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 					$output->writeln(' aborted.');
 					if ($originallyEnabled) {
 						$output->writeln('Server side encryption remains enabled');
-						$this->appConfig->setValueBool('core', 'encryption_enabled', true);
+						$this->config->setAppValue('core', 'encryption_enabled', 'yes');
 					}
 				} elseif (($uid !== '') && $originallyEnabled) {
 					$output->writeln('Server side encryption remains enabled');
-					$this->appConfig->setValueBool('core', 'encryption_enabled', true);
+					$this->config->setAppValue('core', 'encryption_enabled', 'yes');
 				}
 				$this->resetMaintenanceAndTrashbin();
 				return 0;
 			}
 			if ($originallyEnabled) {
 				$output->write('Enable server side encryption... ');
-				$this->appConfig->setValueBool('core', 'encryption_enabled', true);
+				$this->config->setAppValue('core', 'encryption_enabled', 'yes');
 				$output->writeln('done.');
 			}
 			$output->writeln('aborted');
 			return 1;
 		} catch (\Exception $e) {
 			// enable server side encryption again if something went wrong
 			if ($originallyEnabled) {
-				$this->appConfig->setValueBool('core', 'encryption_enabled', true);
+				$this->config->setAppValue('core', 'encryption_enabled', 'yes');
 			}
 			$this->resetMaintenanceAndTrashbin();
 			throw $e;

tests/Core/Command/Encryption/DecryptAllTest.php

@@ -10,7 +10,6 @@
 
 use OC\Core\Command\Encryption\DecryptAll;
 use OCP\App\IAppManager;
-use OCP\IAppConfig;
 use OCP\IConfig;
 use PHPUnit\Framework\MockObject\MockObject;
 use Symfony\Component\Console\Helper\QuestionHelper;
@@ -20,7 +19,6 @@
 
 class DecryptAllTest extends TestCase {
 	private MockObject&IConfig $config;
-	private MockObject&IAppConfig $appConfig;
 	private MockObject&IAppManager $appManager;
 	private MockObject&InputInterface $consoleInput;
 	private MockObject&OutputInterface $consoleOutput;
@@ -31,7 +29,6 @@ protected function setUp(): void {
 		parent::setUp();
 
 		$this->config = $this->createMock(IConfig::class);
-		$this->appConfig = $this->createMock(IAppConfig::class);
 		$this->appManager = $this->createMock(IAppManager::class);
 		$this->questionHelper = $this->createMock(QuestionHelper::class);
 		$this->decryptAll = $this->createMock(\OC\Encryption\DecryptAll::class);
@@ -74,7 +71,6 @@ public function testMaintenanceAndTrashbin(): void {
 		$instance = new DecryptAll(
 			$this->appManager,
 			$this->config,
-			$this->appConfig,
 			$this->decryptAll,
 			$this->questionHelper
 		);
@@ -95,15 +91,14 @@ public function testExecute($encryptionEnabled, $continue): void {
 		$instance = new DecryptAll(
 			$this->appManager,
 			$this->config,
-			$this->appConfig,
 			$this->decryptAll,
 			$this->questionHelper
 		);
 
-		$this->appConfig->expects($this->once())
-			->method('getValueBool')
-			->with('core', 'encryption_enabled')
-			->willReturn($encryptionEnabled);
+		$this->config->expects($this->once())
+			->method('getAppValue')
+			->with('core', 'encryption_enabled', 'no')
+			->willReturn($encryptionEnabled ? 'yes' : 'no');
 
 		$this->consoleInput->expects($this->any())
 			->method('getArgument')
@@ -112,19 +107,18 @@ public function testExecute($encryptionEnabled, $continue): void {
 
 		if ($encryptionEnabled) {
 			$calls = [
-				['core', 'encryption_enabled', false, false],
-				['core', 'encryption_enabled', true, false],
+				['core', 'encryption_enabled', 'no'],
+				['core', 'encryption_enabled', 'yes'],
 			];
-			$this->appConfig->expects($this->exactly(count($calls)))
-				->method('setValueBool')
-				->willReturnCallback(function () use (&$calls): bool {
+			$this->config->expects($this->exactly(count($calls)))
+				->method('setAppValue')
+				->willReturnCallback(function () use (&$calls): void {
 					$expected = array_shift($calls);
 					$this->assertEquals($expected, func_get_args());
-					return true;
 				});
 		} else {
-			$this->appConfig->expects($this->never())
-				->method('setValueBool');
+			$this->config->expects($this->never())
+				->method('setAppValue');
 		}
 		$this->questionHelper->expects($this->once())
 			->method('ask')
@@ -156,27 +150,25 @@ public function testExecuteFailure(): void {
 		$instance = new DecryptAll(
 			$this->appManager,
 			$this->config,
-			$this->appConfig,
 			$this->decryptAll,
 			$this->questionHelper
 		);
 
 		// make sure that we enable encryption again after a exception was thrown
 		$calls = [
-			['core', 'encryption_enabled', false, false],
-			['core', 'encryption_enabled', true, false],
+			['core', 'encryption_enabled', 'no'],
+			['core', 'encryption_enabled', 'yes'],
 		];
-		$this->appConfig->expects($this->exactly(2))
-			->method('setValuebool')
-			->willReturnCallback(function () use (&$calls): bool {
+		$this->config->expects($this->exactly(2))
+			->method('setAppValue')
+			->willReturnCallback(function () use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
-				return true;
 			});
-		$this->appConfig->expects($this->once())
-			->method('getValueBool')
-			->with('core', 'encryption_enabled')
-			->willReturn(true);
+		$this->config->expects($this->once())
+			->method('getAppValue')
+			->with('core', 'encryption_enabled', 'no')
+			->willReturn('yes');
 
 		$this->consoleInput->expects($this->any())
 			->method('getArgument')