test: add test for new getDisplayUser() method in OC\User\Manager

Signed-off-by: Kent Delante <kent@delante.me>
Assisted-by: ClaudeCode:claude-sonnet-5

Author: leftybournes

tests/lib/User/ManagerTest.php

@@ -15,6 +15,8 @@
 use OC\User\User;
 use OCP\Config\IUserConfig;
 use OCP\EventDispatcher\IEventDispatcher;
+use OCP\Federation\ICloudId;
+use OCP\Federation\ICloudIdManager;
 use OCP\ICache;
 use OCP\ICacheFactory;
 use OCP\IConfig;
@@ -34,6 +36,7 @@ class ManagerTest extends TestCase {
 	private ICache&MockObject $cache;
 	private LoggerInterface&MockObject $logger;
 	private IUserManager $manager;
+	private ICloudIdManager $cloudIdManager;
 
 	#[\Override]
 	protected function setUp(): void {
@@ -44,11 +47,12 @@ protected function setUp(): void {
 		$this->cacheFactory = $this->createMock(ICacheFactory::class);
 		$this->cache = $this->createMock(ICache::class);
 		$this->logger = $this->createMock(LoggerInterface::class);
+		$this->cloudIdManager = $this->createMock(ICloudIdManager::class);
 
 		$this->cacheFactory->method('createDistributed')
 			->willReturn($this->cache);
 
-		$this->manager = new Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger);
+		$this->manager = new Manager($this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger, $this->cloudIdManager);
 	}
 
 	public function testGetBackends(): void {
@@ -665,7 +669,7 @@ public function testDeleteUser(): void {
 			->method('getAppValue')
 			->willReturnArgument(2);
 
-		$this->manager = new Manager($config, $this->cacheFactory, $this->eventDispatcher, $this->logger);
+		$this->manager = new Manager($config, $this->cacheFactory, $this->eventDispatcher, $this->logger, $this->cloudIdManager);
 		$backend = new \Test\Util\User\Dummy();
 
 		$this->manager->registerBackend($backend);
@@ -687,7 +691,7 @@ public function testGetByEmail(): void {
 			});
 
 		$this->manager = $this->getMockBuilder(Manager::class)
-			->setConstructorArgs([$this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger])
+			->setConstructorArgs([$this->config, $this->cacheFactory, $this->eventDispatcher, $this->logger, $this->cloudIdManager])
 			->onlyMethods(['getUserConfig', 'get'])
 			->getMock();
 		$this->manager->method('getUserConfig')->willReturn($userConfig);
@@ -736,4 +740,22 @@ public function testGetAvatarUrlLight(): void {
 	public function testGetAvatarUrlDark(): void {
 		$this->assertEquals('http://localhost/index.php/avatar/userid/64/dark', $this->manager->getAvatarUrlDark('userid', 64));
 	}
+
+	public function testGetDisplayUser(): void {
+		$userId = 'test@example.com';
+
+		$cloudId = $this->createMock(ICloudId::class);
+		$cloudId->expects($this->once())
+			->method('getDisplayId')
+			->willReturn($userId);
+		$this->cloudIdManager->expects($this->once())
+			->method('resolveCloudId')
+			->with($userId)
+			->willReturn($cloudId);
+
+		$user = $this->manager->getDisplayUser($userId);
+
+		$this->assertEquals($userId, $user->getUID());
+		$this->assertEquals($userId, $user->getDisplayName());
+	}
 }