Does SharpRTSP handle duplicate packets?

[HHCBakker]

I have inherited a project with an open issue wondering if SharpRTSP handles duplicate packets correctly. I have not noticed any issues in the project that might be related to this but I would like to close the issue if it is no longer relevant, hence the question.

The text of the issue reads:

Per RFC 7587: (and surely applicable to other payload types)
"The receiving side MUST be prepared to receive duplicate RTP packets. The receiver MUST provide at most one of those payloads to the Opus decoder for decoding, and it MUST discard the others."

As far as I know, this isn't properly handled, and could result in corrupted audio in case of duplicated packets.

[ngraziano]

Hi,
Yes it is true that in case of UDP transmission you should handle duplicate packet but also out of order one. It is valid for any king of codec.
In practice on a local network this is not really a problem, the RTSP serer do not emit duplicate packet and and there is no L3 router that can duplicate or reorder the UDP packet, maybe on a complex network it may happen. In case of TCP transport it is very unlikely that duplicate, loss or wrong order happen.

This library do not include the remove of duplicate RTP packets (it do not handle client side it only provide incomplete example)

If you just want to handle duplicate, you can in your client code before sending to the IPayloadProcessor, drop the packet if they have the same SequenceNumber as the previous one.

To put the packet in the correct order it may be more complicate and you have to handle the loss of packet.