value.slice() is not a function when prefilled with number

[RANSoftRA]

I am running into an issue when the value of the field is pre-filled with a number (bound with ngModel). Seems like the code is expecting a string as a value - hence the problem when the input value is a number (the slice function is not available).

Error occurs on line 7115 in ngx-material-keyboard-core.js:

    MatKeyboardKeyComponent.prototype.onClick = function (event) {
        ....        
        var value = this.inputValue; // value is a number
        ....
        if (char && this.input) {
            this.inputValue = [value.slice(0, caret), char, value.slice(caret)].join(''); // error here
            this._setCursorPosition(caret + 1);
        }
    };

[davidenke]

Looks like a simple string cast is missing.

[RANSoftRA]

seems like it.

[ydock1]

i've solved this issue and fix a problem with the backspace, how can i pull request? (im new on GitHub)

[RANSoftRA]

@ydock1
Thanks for your afford! This article may help you:
https://help.github.com/articles/creating-a-pull-request-from-a-fork/

[ydock1]

#51 i think is ready,

[RANSoftRA]

@davidenke just wanted to ask when we can expect a new relase which includes the provided bugfix? Just asking, becuause I would need this feature by the end of the month. Cheers

[ydock1]

@RANSoftRA
you can "fix" without wait a new release.
go to "/node_modules/@ngx-material-keyboard/core/esm5/ngx-material-keyboard-core.js" and go to the line "7083" (or this function MatKeyboardKeyComponent.prototype.onClick = function (event) )

and change this 3 lines
1-
var value = this.inputValue == null ? "" : this.inputValue;

2-

this.inputValue = [value.slice(0, caret - 1)].join('');

3-

this.inputValue = caret ? [value.slice(0, caret), char, value.slice(caret)].join('') : value + char;

The only problem with this is that if you make "npm install" you have to modify the file again

[RANSoftRA]

@ydock1 thanks for the quick reply.

I know that I could temporarily change the code under node_modules to make a quick fix. I simply asked if the fix will be present any time soon - otherwise I'll probably have to apply your suggestion.

thanks

[spyter]

Does anyone have an estimate on when this fix will be released?