Skip to content

updateTitle cannot be set to false #6

@chmp

Description

@chmp

Thanks for this great library. Setting it up was extremely simple and it works like a charm. However, I ran into a problem while trying to set updateTitle to false:

The updateTitle config value is set via updateTitle = cfg.updateTitle || updateTitle;. This way the updateTitle config value cannot be set to false, since it then evaluates to its previous value (true). The corresponding line should be replaced via updateTitle = (cfg.updateTitle !== undefined) ? cfg.updateTitle : updateTitle;.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions