[#6] [UI] As a user, I can login, [#7] [UI] As a user, I can logout#32
Open
ghost wants to merge 31 commits into
Open
[#6] [UI] As a user, I can login, [#7] [UI] As a user, I can logout#32ghost wants to merge 31 commits into
ghost wants to merge 31 commits into
Conversation
|
Code coverage is now at 0.00% (0/77 lines) Generated by 🚫 Danger |
ghost
self-assigned this
ghost
changed the title
ghost
marked this pull request as ready for review
mosharaf13
approved these changes
May 26, 2023
sanG-github
reviewed
May 26, 2023
sanG-github
left a comment
sanG-github
left a comment
Collaborator
There was a problem hiding this comment.
It looks good on overall!! 🚀
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
longnd
suggested changes
May 29, 2023
longnd
reviewed
May 29, 2023
sanG-github
requested changes
May 29, 2023
sanG-github
left a comment
sanG-github
left a comment
Collaborator
There was a problem hiding this comment.
How about styling the sign in page? As I see Mosharaf implemented it in this PR.
Contributor
pls ignore this requres, since we're using Devise, re-testing its behavior is redundant. |
added 3 commits
May 30, 2023 10:25
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| submit_authentication_form(user.email, 'invalid') | ||
|
|
||
| expect(page).to have_text "Invalid Email or password." |
There was a problem hiding this comment.
| Prefer single-quoted strings when you don't need string interpolation or special symbols. |
| within selectors[:auth_form] do | ||
| fill_in selectors[:email_field], with: email | ||
| fill_in selectors[:password_field], with: password | ||
| click_button "Log in" |
There was a problem hiding this comment.
| Prefer single-quoted strings when you don't need string interpolation or special symbols. |
Author
ghost
force-pushed
the
feature/ui-log-in-log-out
branch
from
f972ed6 to
d2abab7
Compare
Contributor
|
@topnimble can you resolve the failing checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What happened 👀
Add Bootstrap UI.
Insight 📝
Some changes of log in page are in https://github.com/mosharaf13/google-scrapper-ruby/pull/36/files.
Proof Of Work 📹