From 29b88a1a5b1d165fa8479a12230b7cb3c8bd3c11 Mon Sep 17 00:00:00 2001 From: janhencic Date: Mon, 19 Jan 2026 21:04:53 +0000 Subject: [PATCH] Use error on invalid UTF-8 output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This update returns ColmenaError::BadOutput instead of unwrapping when capturing a command’s output. I used from_utf8_lossy to keep the output readable with replacement characters for invalid sequences, avoiding a panic on non-UTF-8 bytes. --- src/util.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util.rs b/src/util.rs index ffbfef5..1172677 100644 --- a/src/util.rs +++ b/src/util.rs @@ -132,8 +132,9 @@ impl CommandExt for Command { .await?; if output.status.success() { - // FIXME: unwrap - Ok(String::from_utf8(output.stdout).unwrap()) + String::from_utf8(output.stdout).map_err(|err| ColmenaError::BadOutput { + output: String::from_utf8_lossy(err.as_bytes()).to_string(), + }) } else { Err(output.status.into()) }