Skip to content

Minimize global objects #68

@sbreitbart-NOAA

Description

@sbreitbart-NOAA

Hmm, yes, I think it is a global, then - perhaps a cleaner thing to do more in line with a functional coding style is to make a function, perhaps get_nmfs_palettes(), that returns the list object that can then be called when wanting to use nmfs_palette. I also noticed nmfs_colors appears to be a global object as well.

This seems like it's not really in scope for this PR, so feel free to leave as is and perhaps open an issue to work in the future - or don't, because the package is really small, so the risk of globals is probably not a big issue right now.

Originally posted by @k-doering-NOAA in #67 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions