Commit 5bc746b
committed
Fix pipeline chain skipping failed steps
on_done was called unconditionally in the finally block, so when a step
failed (e.g. canvasapi missing → exit code 1), the pipeline silently
advanced to the next step. This caused "Generate notes" to run even
though "Download videos" had failed — and since console.clear() runs
at the start of each step, the user only saw the last running step.
Fix: initialize rc = -1 before the try block, only call on_done when
rc == 0. A failed step now halts the chain and leaves the error visible.1 parent f8d2660 commit 5bc746b
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
449 | 449 | | |
450 | 450 | | |
451 | 451 | | |
| 452 | + | |
452 | 453 | | |
453 | 454 | | |
454 | 455 | | |
| |||
490 | 491 | | |
491 | 492 | | |
492 | 493 | | |
493 | | - | |
| 494 | + | |
494 | 495 | | |
495 | 496 | | |
496 | 497 | | |
| |||
502 | 503 | | |
503 | 504 | | |
504 | 505 | | |
505 | | - | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
506 | 509 | | |
507 | 510 | | |
508 | 511 | | |
| |||
0 commit comments