From 5e115431592b580725d28aeba5337b99e8877e02 Mon Sep 17 00:00:00 2001 From: nitram509 Date: Wed, 30 Nov 2022 08:36:32 +0100 Subject: [PATCH 1/2] add 1.18 and 1.19 in the test matrix --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f80aaee..fa45c32 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,7 +4,7 @@ jobs: test: strategy: matrix: - go-version: [1.16.x, 1.17.x] + go-version: [1.16, 1.17, 1.18, 1.19] os: [ubuntu-latest, macos-latest, windows-latest] runs-on: ${{ matrix.os }} steps: From ef3b860686677c29dcc95aa5b85571771a6bd837 Mon Sep 17 00:00:00 2001 From: nitram509 Date: Sun, 23 Oct 2022 17:22:11 +0200 Subject: [PATCH 2/2] remove js.Wrapper, because removed with Go 1.18 onwards, see Go 1.18 release notes: https://tip.golang.org/doc/go1.18 --- value.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/value.go b/value.go index 1bc3006..d741997 100644 --- a/value.go +++ b/value.go @@ -27,7 +27,7 @@ func (v Value) JSValue() js.Value { // ValueOf returns the Go value as a new value. func ValueOf(i interface{}) Value { switch i.(type) { - case nil, js.Value, js.Wrapper: + case nil, js.Value: return Value{Value: js.ValueOf(i)} default: v := reflect.ValueOf(i)