feat: implement system.autoUpgrade module for periodic upgrades#436
Merged
Conversation
commiterate
reviewed
Mar 26, 2026
jfroche
added a commit
that referenced
this pull request
Mar 27, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
jfroche
added a commit
that referenced
this pull request
Mar 27, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
This was referenced Mar 30, 2026
jfroche
force-pushed
the
build-with-refresh
branch
3 times, most recently
from
181a420 to
bb04f57
Compare
jfroche
added a commit
that referenced
this pull request
Apr 8, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
jfroche
added a commit
that referenced
this pull request
Apr 10, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
picnoir
pushed a commit
that referenced
this pull request
Apr 10, 2026
We parse the directive from the unit file text and skip restarting the service if X-RestartIfChanged=false is set required for #436
picnoir
force-pushed
the
feat-stop-on-removal
branch
from
3644af3 to
208990f
Compare
picnoir
approved these changes
Apr 13, 2026
commiterate
reviewed
Apr 13, 2026
| systemd.services.system-manager-upgrade = { | ||
| description = "System Manager Upgrade"; | ||
|
|
||
| restartIfChanged = false; |
Contributor
There was a problem hiding this comment.
Is this property a typo? Seems like it should be serviceConfig.X-RestartIfChanged.
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Good catch, that's a Nixpkgs helper we currently do not have ported to system-manager: https://github.com/NixOS/nixpkgs/blob/2353f2a8a524d93eb4746d817382e50521018a09/nixos/lib/systemd-lib.nix#L795
Member
Author
There was a problem hiding this comment.
X-RestartIfChanged should be correctly managed by #438
We call systemd-lib.serviceToUnit in
system-manager/nix/modules/systemd.nix
Line 198 in 538a7fa
Contributor
There was a problem hiding this comment.
Ah! Right! I forgot we're passing the services through the upstream lib!
commiterate
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #450
Fixes #253