Skip to content

Commit 0395fd6

Browse files
committed
docs(spec): state the pagination row bound as true before and after the per-kind limit retirement
The changeset, the form comment and the pin's docblock said `pagination.pageSize` is a view's only row bound. The kanban, gallery and timeline configs still declare a per-kind `limit` until its retirement lands, so all three now say only that `pagination.pageSize` is the row bound every view type carries. Wording only; no form entry, test logic, bundle or translation moves. Claude-Session: https://claude.ai/code/session_013RDBh5DqXd2xnLwvHLgLFr Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2bfeee4 commit 0395fd6

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎.changeset/19814-view-form-pagination-all-kinds.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55

66
The Studio view form (`viewForm`, served by `METADATA_FORM_REGISTRY.view`) now offers `pagination` for every view type, not only grids.
77

8-
`pagination.pageSize` is the one row bound a view carries; for a kanban, gallery or timeline view it is the only one. The form used to place `pagination` inside the grid-only `Table options` section (shown when `type` is `grid` or unset), so an author editing any other view type could not see or set it without editing the metadata by hand. It now has its own collapsed `Pagination` section with no visibility condition. `Table options` keeps `resizable`, `compactToolbar`, `rowHeight` and `selection`, still for grids only.
8+
`pagination.pageSize` is the row bound every view type carries. The form used to place `pagination` inside the grid-only `Table options` section (shown when `type` is `grid` or unset), so an author editing any other view type could not see or set it without editing the metadata by hand. It now has its own collapsed `Pagination` section with no visibility condition. `Table options` keeps `resizable`, `compactToolbar`, `rowHeight` and `selection`, still for grids only.
99

1010
No schema changed: every view type already accepted `pagination`. `@objectstack/platform-objects` ships the new section's label and description in its metadata-form translation bundles (en, zh-CN, ja-JP, es-ES).

‎packages/spec/src/ui/view-form-pagination.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
*
77
* ## What is being pinned
88
*
9-
* Maintainer ruling D on #19228: a view carries one row bound,
10-
* `pagination.pageSize`. For a kanban, gallery or timeline view it is the only
11-
* one. The form used to offer `pagination` only inside `table_options`
9+
* `pagination.pageSize` is the row bound every view type carries; maintainer
10+
* ruling D on #19228 makes it the direction for a view's row bound. The form
11+
* used to offer `pagination` only inside `table_options`
1212
* (`visibleWhen: "data.type == 'grid' || data.type == null"`), so an author
1313
* editing any other view type could not see or set that bound short of editing
1414
* the metadata by hand. Two halves, both asserted:

‎packages/spec/src/ui/view.form.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ export const viewForm = defineForm({
6161
],
6262
},
6363
// `pagination` is NOT grid-only: every view type accepts it, and
64-
// `pagination.pageSize` is the one row bound a view carries (maintainer
65-
// ruling D on #19228) — for a kanban, gallery or timeline view the only
66-
// one. Its own section with no `visibleWhen` puts it in front of every
67-
// type; inside `table_options` a non-grid author could not reach it.
64+
// `pagination.pageSize` is the row bound every view type carries (maintainer
65+
// ruling D on #19228 makes it the direction for a view's row bound). Its own
66+
// section with no `visibleWhen` puts it in front of every type; inside
67+
// `table_options` a non-grid author could not reach it.
6868
{
6969
name: 'pagination',
7070
label: 'Pagination',

0 commit comments

Comments
 (0)