Merge remote-tracking branch 'origin/main' into claude/issue-21470-save-door-every-type

Author: claude

.changeset/20595-metadata-core-provenance-anchors.md

@@ -0,0 +1,20 @@
+---
+'@objectstack/metadata-core': patch
+---
+
+Provenance comments in `@objectstack/metadata-core` cite the commits that decided them, not tracker numbers that no longer resolve
+
+Clause-②: no
+
+Docblocks and comments across the package cited issue-tracker numbers that now answer 404 on GitHub.
+Each now cites the commit in this repository's history that made the decision it describes, with two
+exceptions: two comments on `retiredFromLoadPath`'s jurisdiction (in `artifact-forward-conversion.ts`
+and its test) cite ADR-0087, which records that determination, and five comments that meant an
+objectui issue now spell it `objectui#6111`, as they already spelled `objectui#6110` beside it. One
+commit citation sits inside a maintainer ruling quoted in `record-organization.ts`: the number there
+became the bracketed editorial substitution `[commit 7901b2dd2]`, the commit that landed the ruling it
+names, and the rest of the quotation is unchanged. Some of these docblocks sit on exported members, so
+the reworded text appears in the published declaration files (`index.d.ts` / `index.d.cts`,
+`testing.d.ts` and a shared declaration chunk); the JavaScript output and its sourcemaps do not change.
+
+Comment only: no export, type, error code, status, message text or runtime behaviour changes.

.changeset/21496-text-face-exit-signal.md

@@ -0,0 +1,16 @@
+---
+'@objectstack/cli': patch
+---
+
+fix(cli): `os package install`, `os package publish` and `os plugin sign` print one error line per refusal (#21496)
+
+Clause-②: no
+
+`os package install ./does-not-exist.json` printed `✗ Cannot read artifact: ENOENT …` and then a second line, `✗ EEXIT: 1`. The exit status, 1, was right. The extra line came from the command's own `catch`: the `this.exit(1)` inside its `try` throws oclif's exit signal, and the `catch` reported the signal as an error.
+
+The same `catch` sat in two more commands:
+
+- **`os package publish`.** Every refusal it makes printed the extra `✗ EEXIT: 1` line. Examples are an unreadable artifact, an invalid manifest id, no cloud login, a failed package registration and a failed version publish. An `--icon-file` whose image type it cannot infer printed three error lines: the refusal, then `✗ Cannot read --icon-file '…': EEXIT: 1`, then `✗ EEXIT: 1`.
+- **`os plugin sign`.** A signature that failed its self-verification printed `✗ Self-verification error: EEXIT: 1` under the refusal.
+
+Each refusal is now one error line, and every exit status is unchanged. A script that filtered out the `EEXIT` line can drop that filter.

.changeset/21509-verify-select-multiple.md

@@ -0,0 +1,12 @@
+---
+"@objectstack/verify": patch
+---
+
+`os verify` writes each derived sample in the shape the engine stores it: a `select` declared `multiple: true` is written as a list and compared as a set
+
+Clause-②: no
+
+- The CRUD round-trip derivation now asks `@objectstack/spec`'s `isMultiValueField` whether a field is multi-valued, the same predicate the engine stores by. Before, the `select` / `radio` sample was one scalar option code compared `equal` whatever the field declared, so a multi-valued `select` read back as a one-element list and was reported as a fidelity gap the engine does not have. The shipped `examples/app-todo` (`todo_task.tags`) failed `os verify` with exit 1 on exactly that, and now passes.
+- A single-valued `select` or `radio` keeps its scalar sample and its `equal` comparison. `multiselect` and `checkboxes` are unchanged.
+- A relational field's `multiple` is answered by the same predicate. A `lookup` declared `multiple: true` still receives a list of ids. A `master_detail` or `tree` field carrying `multiple: true` now receives one id, which is how the engine stores those types. The spec already refuses `multiple` on those types at parse, so only an unparsed config could reach this.
+- No export, type or accept-set change.

packages/cli/src/commands/package/install.ts

@@ -26,7 +26,7 @@ import { readFile } from 'node:fs/promises';
 import { existsSync } from 'node:fs';
 import { resolve as resolvePath } from 'node:path';
 import { Args, Command, Flags } from '@oclif/core';
-import { printHeader, printKV, printSuccess, printError, printStep } from '../../utils/format.js';
+import { printHeader, printKV, printSuccess, printError, printStep, isExitSignal } from '../../utils/format.js';
 
 export default class PackageInstall extends Command {
   static override description =
@@ -246,6 +246,7 @@ export default class PackageInstall extends Command {
         console.log(`    ${storageDir}`);
       }
     } catch (error) {
+      if (isExitSignal(error)) throw error;
       printError((error as Error).message);
       this.exit(1);
     }

packages/cli/src/commands/package/publish.ts

@@ -32,7 +32,7 @@ import { readFile } from 'node:fs/promises';
 import { resolve as resolvePath, basename, dirname, isAbsolute } from 'node:path';
 import { Args, Command, Flags } from '@oclif/core';
 import { PackageSchema } from '@objectstack/spec/marketplace';
-import { printHeader, printKV, printSuccess, printError, printStep } from '../../utils/format.js';
+import { printHeader, printKV, printSuccess, printError, printStep, isExitSignal } from '../../utils/format.js';
 import { DEFAULT_CLOUD_URL, tryReadCloudConfig } from '../../utils/cloud-config.js';
 import { resolveCloudActiveEnvironmentId } from '../../utils/active-environment.js';
 import { readErrorMessage } from '../../utils/response-envelope.js';
@@ -665,6 +665,7 @@ export default class PackagePublish extends Command {
           const iconUrl = iconRes.body?.data?.icon_url ?? iconRes.body?.icon_url;
           if (iconUrl) printKV('  Icon URL', String(iconUrl));
         } catch (err: any) {
+          if (isExitSignal(err)) throw err;
           printError(`Cannot read --icon-file '${iconPath}': ${err.message}`);
           this.exit(1);
           return;
@@ -794,6 +795,7 @@ export default class PackagePublish extends Command {
         for (const v of violations) console.log(`    • ${v}`);
       }
     } catch (error) {
+      if (isExitSignal(error)) throw error;
       printError((error as Error).message);
       this.exit(1);
     }

packages/cli/src/commands/plugin/sign.ts

@@ -19,7 +19,7 @@ import { createPublicKey } from 'node:crypto';
 import { resolve as resolvePath } from 'node:path';
 import { Args, Command, Flags } from '@oclif/core';
 import { parseSignature, signPayload, verifyPayload } from '@objectstack/core';
-import { printError, printHeader, printKV, printStep, printSuccess } from '../../utils/format.js';
+import { isExitSignal, printError, printHeader, printKV, printStep, printSuccess } from '../../utils/format.js';
 import { OSPLUGIN_EXT } from '../../utils/osplugin.js';
 
 export default class PluginSign extends Command {
@@ -99,6 +99,7 @@ export default class PluginSign extends Command {
         return;
       }
     } catch (err) {
+      if (isExitSignal(err)) throw err;
       printError(`Self-verification error: ${(err as Error).message}`);
       this.exit(1);
       return;