Skip to content

Commit 099e5ff

Browse files
committed
ci(test-core): say which reader self-test cases are digest cases and which are controls
Ablating the digest path (sliceOfLeg never consulting OS_TEST_SHARD) reds seven of the env-carried-slice cases; the passthrough, empty-value and unrelated-variable cases stay green by design. The battery comment claimed every case fails that way. Comment only. Claude-Session: https://claude.ai/code/session_01TdiauJaVCHuj45EzZGUxHh Co-authored-by: Claude <noreply@anthropic.com>
1 parent 95b97ef commit 099e5ff

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎scripts/measure-test-shard-timings.mjs‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,10 +1149,14 @@ function selfTest() {
11491149
// -- ENV-CARRIED SLICES (#19278) --------------------------------------------
11501150
//
11511151
// Test Core's slice leg carries k/n in OS_TEST_SHARD, which a summary records
1152-
// only as a sha256 digest in `environmentVariables.configured`. Each case
1153-
// below fails in the #16173 direction if the digest path is dropped: a slice
1154-
// read as a whole package. `sliced` stands in for FILE_SHARDED_PACKAGES so the
1155-
// fixtures keep the short names above, and one case reads the REAL map.
1152+
// only as a sha256 digest in `environmentVariables.configured`. With the
1153+
// digest path dropped, the digest cases below fail: a slice read as a whole
1154+
// package (the #16173 direction), or an unmatched or conflicting digest let
1155+
// through. Three are controls that hold either way -- the passthrough
1156+
// carrier, an empty value, an unrelated variable -- and pin what the digest
1157+
// path must NOT read. Each case was ablated against the code it pins.
1158+
// `sliced` stands in for FILE_SHARDED_PACKAGES so the fixtures keep the short
1159+
// names above, and one case reads the REAL map.
11561160
battery('env-carried slices (#19278)');
11571161
const digestOf = (value) => createHash('sha256').update(value).digest('hex');
11581162
const envTask = (pkg, start, end, value, extra = {}) => ({

0 commit comments

Comments
 (0)