Skip to content

Commit 1f9ae64

Browse files
committed
fix(client,spec): one owner for the README install-example pin, and declare the union's dropped refinements
`main` landed #18771, which fixes the same README example and adds `readme-package-install-example.test.ts` — a corpus reader over every `packages.install` literal in the published README. Two files reading the same README to ask the same question is a duplicate owner, so the F4 additions move INTO that file and the branch's own copy is dropped: the corpus is now parsed against `PackageInstallBodySchema` wrapped exactly as `packages.install` sends it and bare as the door reads it, and the pre-#18058 literal is pinned refused so a schema relaxation cannot make the block vacuous. The README keeps main's landed literal (`type: 'plugin'`, no deprecated `namespace`) plus this card's prose and the `overwrite` opt-in line. `api/PackageInstallBody` is a new published schema whose bare branch carries the `navigationContributions` refinements `z.toJSONSchema()` cannot project, so `dropped-refinements.baseline.json` — which landed on main after this branch forked — gains the entry `build-schemas.ts` printed, beside the identical `api/PackageInstallRequest` and `api/InstallPackageRequest` rows. Claude-Session: https://claude.ai/code/session_01LvwGppdonww4zGLWZo5rho Co-authored-by: Claude <noreply@anthropic.com>
1 parent 49ebeda commit 1f9ae64

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎packages/spec/dropped-refinements.baseline.json‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,12 @@
402402
"data.titleFormat.options[1]"
403403
]
404404
},
405+
"api/PackageInstallBody": {
406+
"sites": [
407+
"options[1].navigationContributions.element.items.element.lazy.options[0]",
408+
"options[1].navigationContributions.element.items.element.lazy.options[0].visible.options[1]"
409+
]
410+
},
405411
"api/PackageInstallRequest": {
406412
"sites": [
407413
"manifest.navigationContributions.element.items.element.lazy.options[0]",

0 commit comments

Comments
 (0)