fix(spec): follow ADR-0122's author/parsed alias convention on the new types

`QueryWithTransport` is the author state and `QueryWithTransportParsed` the
parsed one; `QueryTransportParamsParsed` names the parsed transport bag.
`check:spec-parsed-alias` named both, and the test-side engine mock is typed
with the parameters it is really called with.

Claude-Session: https://claude.ai/code/session_01LvwGppdonww4zGLWZo5rho
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

.changeset/16066-query-transport-dialect-declared.md

@@ -9,11 +9,11 @@ The query TRANSPORT dialect is declared, and the `findData` fold now derives fro
 
 **New in `@objectstack/spec/data`** (8 exports, 0 removed):
 
-- `QueryTransportParamsSchema` / `QueryTransportParams` — the transport parameters, each carrying the value of the canonical slot it folds onto.
+- `QueryTransportParamsSchema` / `QueryTransportParams` / `QueryTransportParamsParsed` — the transport parameters, each carrying the value of the canonical slot it folds onto.
 - `QUERY_TRANSPORT_ALIAS_SLOTS` — `RPC_QUERY_ALIAS_SLOTS` extended with the transport-only spellings (`filters` / `$filter` onto `where`, `$expand` onto `expand`).
 - `QUERY_TRANSPORT_DOLLAR_ALIASES` — the `$`-to-bare pairs that fold in two hops (`$top` onto `top` onto `limit`).
 - `QUERY_TRANSPORT_DOLLAR_PARAMS` — the `$` spellings a boundary quotes when it refuses an undeclared one.
-- `QueryWithTransportSchema` / `QueryWithTransport` / `QueryWithTransportInput` — the query slot whose declared input is the AST or its transport spelling and whose declared output is the AST.
+- `QueryWithTransportSchema` / `QueryWithTransport` / `QueryWithTransportParsed` — the query slot whose declared input is the AST or its transport spelling and whose declared output is the AST.
 
 **`FindDataRequestSchema.query` is that slot now.** Its `z.input` admits the canonical AST, the transport spelling, or a bag carrying both; its `z.output` is still the AST, reached by a transform driven by the two tables. The transport form is declared as the FLATTENED SPELLING of the canonical AST with a 1:1 alias table — never as a second semantics — so `QuerySchema` itself is untouched and still drops a `$` key as unknown.
 

packages/metadata-protocol/src/protocol.query-transport-dialect.test.ts

@@ -113,7 +113,10 @@ const SCHEMA = {
 const USER_SCHEMA = { name: 'sys_user', nameField: 'name', fields: { name: { name: 'name', type: 'text' } } };
 
 function makeProtocol() {
-    const find = vi.fn(async () => [] as unknown[]);
+    // Typed with the parameters the engine is really called with, so the
+    // option-bag read below is `calls[0][1]` rather than an out-of-range index
+    // on a zero-arity tuple.
+    const find = vi.fn(async (_object?: string, _options?: unknown) => [] as unknown[]);
     const count = vi.fn(async () => 0);
     const engine = {
         registry: {

packages/spec/api-surface/data.json

@@ -509,9 +509,10 @@
     "QueryInput (type)",
     "QuerySchema (const)",
     "QueryTransportParams (type)",
+    "QueryTransportParamsParsed (type)",
     "QueryTransportParamsSchema (const)",
     "QueryWithTransport (type)",
-    "QueryWithTransportInput (type)",
+    "QueryWithTransportParsed (type)",
     "QueryWithTransportSchema (const)",
     "RAW_FILE_VALUES_CONTEXT_KEY (const)",
     "READ_ONLY_BELONGS_ON_DATASOURCE (const)",

packages/spec/export-origins/data.json

@@ -498,9 +498,10 @@
     "QueryInput": "src/data/query.zod.ts#QueryInput (type)",
     "QuerySchema": "src/data/query.zod.ts#QuerySchema (const)",
     "QueryTransportParams": "src/data/data-engine.zod.ts#QueryTransportParams (type)",
+    "QueryTransportParamsParsed": "src/data/data-engine.zod.ts#QueryTransportParamsParsed (type)",
     "QueryTransportParamsSchema": "src/data/data-engine.zod.ts#QueryTransportParamsSchema (const)",
     "QueryWithTransport": "src/data/data-engine.zod.ts#QueryWithTransport (type)",
-    "QueryWithTransportInput": "src/data/data-engine.zod.ts#QueryWithTransportInput (type)",
+    "QueryWithTransportParsed": "src/data/data-engine.zod.ts#QueryWithTransportParsed (type)",
     "QueryWithTransportSchema": "src/data/data-engine.zod.ts#QueryWithTransportSchema (const)",
     "RAW_FILE_VALUES_CONTEXT_KEY": "src/data/field-value.zod.ts#RAW_FILE_VALUES_CONTEXT_KEY (const)",
     "READ_ONLY_BELONGS_ON_DATASOURCE": "src/data/driver/common.zod.ts#READ_ONLY_BELONGS_ON_DATASOURCE (const)",

packages/spec/src/data/data-engine.zod.ts

@@ -833,9 +833,16 @@ function foldQueryTransportBag(
   return bag;
 }
 
-/** The transport query parameters, as an input shape. */
+/** The transport query parameters, as an author writes them (ADR-0122). */
 export type QueryTransportParams = z.input<typeof QueryTransportParamsSchema>;
 
+/**
+ * The transport query parameters after a parse (ADR-0122). Not identical to
+ * {@link QueryTransportParams}: `$expand`'s record arm carries nested
+ * `QuerySchema` values, whose author and parsed states differ.
+ */
+export type QueryTransportParamsParsed = z.infer<typeof QueryTransportParamsSchema>;
+
 /**
  * What a query slot that serves a transport boundary DECLARES as its input:
  * the canonical QueryAST, the transport spelling, or a bag carrying both.
@@ -847,7 +854,7 @@ export type QueryTransportParams = z.input<typeof QueryTransportParamsSchema>;
  * re-created this card's own defect one size down: a shape the door accepts
  * that the declaration denies.
  */
-export type QueryWithTransportInput = QueryInput & Partial<QueryTransportParams>;
+export type QueryWithTransport = QueryInput & Partial<QueryTransportParams>;
 
 /**
  * A query slot whose declared INPUT is the canonical AST or its transport
@@ -860,7 +867,7 @@ export type QueryWithTransportInput = QueryInput & Partial<QueryTransportParams>
  * widening provably unable to narrow anything: every input that parsed before
  * still parses, by the same schema, with the same issues.
  */
-export const QueryWithTransportSchema: z.ZodType<QueryAST, QueryWithTransportInput> = lazySchema(() =>
+export const QueryWithTransportSchema: z.ZodType<QueryAST, QueryWithTransport> = lazySchema(() =>
   z.union([
     z.record(z.string(), z.unknown())
       .transform((bag, ctx) => foldQueryTransportBag(
@@ -869,15 +876,15 @@ export const QueryWithTransportSchema: z.ZodType<QueryAST, QueryWithTransportInp
       ))
       .pipe(QuerySchema as unknown as z.ZodType<QueryAST, Record<string, unknown>>),
     QuerySchema,
-  ]) as unknown as z.ZodType<QueryAST, QueryWithTransportInput>,
+  ]) as unknown as z.ZodType<QueryAST, QueryWithTransport>,
 );
 
 /**
  * What a transport-aware query slot PARSES TO — the canonical QueryAST, in
- * every spelling. The declared output is deliberately the AST alone: a
- * consumer reading a parsed query never sees a transport key.
+ * every spelling (ADR-0122). The declared output is deliberately the AST
+ * alone: a consumer reading a parsed query never sees a transport key.
  */
-export type QueryWithTransport = z.infer<typeof QueryWithTransportSchema>;
+export type QueryWithTransportParsed = z.infer<typeof QueryWithTransportSchema>;
 
 
 export const DataEngineFindRequestSchema = lazySchema(() => z.object({