Skip to content

Commit 3247efe

Browse files
committed
docs(plugin-security): cite the surviving insert-check commit instead of a card that no longer resolves
The four comment lines this change rewrote named a card that answers 404 on the board. They now name the surviving record, commit a016f08 (the insert-side check), and say in words that the original card no longer resolves. Unchanged lines elsewhere in the file are left as they are. Claude-Session: https://claude.ai/code/session_01Evb5jFDZGKQE9KG4jbMfMF Co-authored-by: Claude <noreply@anthropic.com>
1 parent 16a28ad commit 3247efe

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎packages/plugins/plugin-security/src/security-plugin.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ export function hasPlatformAdminCapability(held: ReadonlySet<string>): boolean {
204204
}
205205

206206
/**
207-
* [#16608] (no longer resolves; the live record is commit a016f08b8a)
207+
* [insert-check commit a016f08b8a] (the original card no longer resolves)
208208
* The write `check` for the writes this middleware cannot judge on
209209
* its own, installed on the operation context for the engine to run on the
210210
* rows that will be stored: every row of an insert, single or array, once the
@@ -1815,7 +1815,7 @@ export class SecurityPlugin implements Plugin {
18151815

18161816
// Register security middleware
18171817
ql.registerMiddleware(async (opCtx: any, next: () => Promise<void>) => {
1818-
// [#16608] (no longer resolves; the live record is commit a016f08b8a)
1818+
// [insert-check commit a016f08b8a] (the original card no longer resolves)
18191819
// The write `check` step 3.6 installs on the operation context
18201820
// for the engine to run: on an insert, after `beforeInsert`; [#19950] on
18211821
// a predicate update, over every matched row once the payload is final.
@@ -3077,7 +3077,7 @@ export class SecurityPlugin implements Plugin {
30773077
};
30783078
const satisfiesCheck = (image: Record<string, unknown>): boolean =>
30793079
checkParts.every((f) => matchesFilterCondition(image as any, f as any));
3080-
// [#16608] (no longer resolves; the live record is commit a016f08b8a)
3080+
// [insert-check commit a016f08b8a] (the original card no longer resolves)
30813081
// The judgement the engine runs: every image it hands over
30823082
// must pass, and the first that fails refuses the whole write. The
30833083
// compiled filter is captured HERE — while the caller's permission
@@ -3095,7 +3095,7 @@ export class SecurityPlugin implements Plugin {
30953095
});
30963096

30973097
if (opCtx.operation === 'insert') {
3098-
// [#16608] (no longer resolves; the live record is commit a016f08b8a)
3098+
// [insert-check commit a016f08b8a] (the original card no longer resolves)
30993099
// The engine runs it on the rows the `beforeInsert` chain
31003100
// produced — [#19964] every row of an array insert.
31013101
writeImageCheckSeam = newWriteImageCheck();

0 commit comments

Comments
 (0)